| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
Now that we've fixed all known best-practices validation errors, we
should be able to enable this flag wihout producing needless noise.
Acked-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Before this, we just assumed our preferred color-format was available.
Now we instead look for it, and fall back to the first format if not
found.
We can probably do better in the future, though. Maybe we should prefer
format with more bits instead of having a single preferred format?
Acked-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
| |
There's no point in redoing all of the swapchain configuration when
resizing the window; yeah, something's changed, but not *everything*.
Let's move all configuration decisions to its own function, which runs
before all the other logic. This is going to help us properly pick color
formats in the next patch also.
Acked-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
|
|
|
| |
While I'm not convinced this should have been considered a best practice
in the first place, the benefits from not having noise like this when
running with validation layers is enough to convince me that it's better
to do this than not to.
Acked-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
|
| |
This adds a vk_layer_settings.txt file that we wire up when running
with the meson devenv feature. That enables some extra validation.
Acked-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
|
| |
Otherwise, we end up waiting on an unsignaled semaphore when resizing,
which isn't legal.
Acked-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
| |
This adds a few missing subpass-dependencies to the render-pass.
Acked-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
| |
Without this, we end up with sync-hazards, it seems.
Acked-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
|
|
| |
Otherwise on those demos the graphics will never update on Wayland. The
X11 WSI forces a redraw on each keypress so this went unnoticed for a
long time.
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
|
|
|
|
| |
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
|
|
|
|
| |
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
|
|
|
|
|
|
|
| |
Despite the fact that those demos were originally hardcoded to X11, they
actually run pretty well on Wayland!
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
|
|
|
|
| |
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
|
|
|
|
| |
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
|
|
|
|
|
|
|
|
|
|
| |
This is no-op until the build system is hooked up to use it.
Note: the ifdefs surrounding _eglutGetWindowSystemInterface() in eglut.c
are temporary and will be ripped out with the entire old WSI code
in another commit in this series.
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
|
|
|
|
|
|
|
| |
Similar to the Wayland commit - renaming, making things static, and adding
a new x11_wsi_interface() function.
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
|
|
|
|
|
|
|
|
| |
This is copy-pasted from eglut_wayland.c, the only change that has been
made is adding a wayland_wsi_interface() function, renaming the _eglut*()
functions, and making them static.
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
|
|
|
|
|
|
|
| |
The goal is to unify the *_x11 and *_wayland binaries into one, just like
how the Vulkan demo does it.
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
|
|
|
|
| |
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
|
|
|
|
| |
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When build without GLVND, Mesa provides GLX as a part of libGL, just
like XQuartz does on MacOS. There's nothing really macOS specific about
this fallback, so let's drop the condition.
And just for good measure, let's add in dep_gl as a dependency for
the header-check here, in case some one decides to install libGL outside
of the default include directory.
Fixes: 34300551 ("meson: explicitly check for glx dependency")
Closes: https://gitlab.freedesktop.org/mesa/demos/-/issues/36
Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
| |
uint is not a standard type name and fails to build against musl libc
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
|
| |
|
|
|
|
|
|
|
|
| |
This fixes the OSMesa demos for me, and matches what we did for the old
Autotools build system.
Closes: https://gitlab.freedesktop.org/mesa/demos/-/issues/35
Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is ancient code that hasn't been hooked up to the build system
since the conversion to autoconf, back in 2007.
The code is here to support Mesa on Glide, which isn't something that
hasn't been supported in Mesa since Mesa 7.2/3, released in 2009. We
had a dummy implementation in Mesa that did nothing and always reported
failure until 2017, but now even that is gone.
It's about time to let this code go, as it has no chance to even build
on new Mesa versions.
Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
|
|
| |
We need this for CI to work now, due to some changes on the gitlab
infrastructure.
See this link for details:
https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/438#what-it-means-for-me-a-maintainer-of-a-project-part-of-gitlabfreedesktoporg
|
|
|
|
|
|
| |
This avoids a compiler-warning on MSVC.
Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
| |
This avoids a compiler-warning on MSVC.
Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
|
|
|
| |
The macro definition warning is about APIENTRY, which glad defines in an
incompatible way with windows.h. But this is fixed in glad 2.x, so instead
of tring to fix every single test to undef APIENTRY, let's just disable
the warning until we land the glad 2.x upgrade.
Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
|
| |
This spelling-error originates in Mesa, but we copied it when we copied
the initial list of warning-disables here. Whoops, let's fix it!
Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
|
|
|
| |
The GL_VERSION_X_Y defines tells us that we have an gl.h file that
supports OpenGL X.Y. Considering it's been well over a decade since
OpenGL 3.2 was released, let's just always assume that it's recent
enough.
Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
|
|
|
| |
The GL_VERSION_X_Y defines tells us that we have an gl.h file that
supports OpenGL X.Y. Considering it's been almost two decades since
OpenGL 2.0 was released, let's just always assume that it's recent
enough.
Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
|
|
| |
The GL_VERSION_X_Y defines tells us that we have an gl.h file that
supports OpenGL X.Y. Considering it's been several decades since OpenGL
1.3 was released, let's just always assume that it's recent enough.
Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
|
|
| |
The GL_VERSION_1_1 define tells us that we have an gl.h file that
supports OpenGL 1.1. Considering it's been several decades since OpenGL
1.1 was released, let's just always assume that it's recent enough.
Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
|
|
|
|
| |
This is needed for Windows support here, because the Windows GL/gl.h
header is missing the definition.
Usually it'd be better to use GLAD for modern GL support on Windows,
but this is an extremely simple program, so it doesn't seem worth it.
Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
|
|
|
| |
This was already done for CMake in af9e1d12 ("cmake: texleak requires
unix."), and we should have added a similar condition in the Meson build
system as well, but we somehow missed it. Add that condition back.
Fixes: 4973b62b ("add a meson build system")
Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
|
|
| |
When we did the switch to C11, we missed a few sources that doesn't
currently build for Windows on CI. Let's fix these.
Fixes: 49439b31 ("meson: update standard to C11 and C++17")
Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
|
| |
gui_app has been deprecated, so let's switch to win_subsystem for the
same effect instead.
Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
|
| |
glGetInfoLogARB is only available in ARB_shader_objects, which we don't
really use. So let's use the GL2 equivialents instead.
Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
|
|
| |
Since we no longer support loading ARB shaders, using these function
pointers makes no sense. They can only ever resolve to one function, and
we already load that one through GLAD.
Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We already call glCompileShader() without fallback to the ARB version in
the CompileShaderText() function. In fact, we've been doing this for
well over a decade now.
The ARB-shader code-path is broken, and it seems nobody noticed until
now.
So let's just get rid of it.
Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
|
| |
There's no good reason to use the ARB versions instead of the non-ARB
versions.
Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
|
|
|
| |
There's a glValidateProgram function in GL2 and later; let's use that
instead of trying to use the ARB function and falling back to nothing.
Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com>
|
|
|
|
| |
Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
|
|
|
|
|
|
|
| |
Theoretically this only affects people compiling eglinfo with EGL 1.2
headers...
Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
|
|
|
|
| |
Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
|
|
|
|
| |
Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
|
|
|
|
|
|
|
| |
The version is returned in an integer consisting of 2 digits. First
digit is the major version, second digit is the minor version.
Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
|
|
|
|
|
|
|
| |
This will be useful in the following patches. Also, this is consistent
with the other Print functions.
Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
|
|
|
|
| |
Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
|