diff options
| author | Ondrej Holy <oholy@redhat.com> | 2020-11-04 09:24:08 +0100 |
|---|---|---|
| committer | Ondrej Holy <oholy@redhat.com> | 2020-11-04 09:24:08 +0100 |
| commit | d11fc07a0b440be9c590152939b1edcb273d710b (patch) | |
| tree | 9669175f808847cebb5fbf63f2f3fe3607d0ea7d | |
| parent | 74e1e6098dac3f9867382dc11b27c0fbc86508aa (diff) | |
| download | nautilus-wip/oholy/mass-rename-crashes.tar.gz | |
batch-rename-utilities: Fix dialog crasheswip/oholy/mass-rename-crashes
The batch rename dialog crashes when it is opened for a second time.
This is because the TrackerSparqlConnection object is unreffed after
the first use. However, nautilus_tracker_get_miner_fs_connection
documentation clearly says that the returned should not be unreffed
because it is globally shared singleton. Let's remove the problematic
g_object_unref statement to fix the crashes.
https://gitlab.gnome.org/GNOME/nautilus/-/issues/1651
| -rw-r--r-- | src/nautilus-batch-rename-utilities.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/nautilus-batch-rename-utilities.c b/src/nautilus-batch-rename-utilities.c index 0412a172e..49b9813ed 100644 --- a/src/nautilus-batch-rename-utilities.c +++ b/src/nautilus-batch-rename-utilities.c @@ -1150,7 +1150,6 @@ check_metadata_for_selection (NautilusBatchRenameDialog *dialog, batch_rename_dialog_query_callback, query_data); - g_object_unref (connection); g_string_free (query, TRUE); } |