| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
creating a scalable icon. Instead it should be possible to get a
scalable icon and then get either an anti-aliased-optimized or
non-anti-alias-optimized version of the icon.
* libnautilus-extensions/nautilus-bookmark.h:
* libnautilus-extensions/nautilus-bookmark.c:
(nautilus_bookmark_get_pixmap_and_mask): Pass FALSE so we get the
non-anti-aliased version.
(nautilus_bookmark_get_pixbuf): Add parameter to indicate if we
want the anti-aliased-optimized version or not.
(nautilus_bookmark_update_icon): Get rid of anti-aliased boolean
here since we are just updating the scalable icon.
(nautilus_bookmark_set_icon_to_default): Get rid of anti-aliased
boolean here since we are just updating the scalable icon.
* libnautilus-extensions/nautilus-icon-container.c:
(nautilus_icon_container_update_icon): Pass in a flag to indicate
if we need the anti-aliased version of the icon or not.
* libnautilus-extensions/nautilus-icon-factory.h:
* libnautilus-extensions/nautilus-icon-factory.c:
(nautilus_scalable_icon_new_from_text_pieces): Removed the
anti-aliased parameter.
(nautilus_scalable_icon_hash), (nautilus_scalable_icon_equal):
Remove the anti-aliased flag. A scalable icon itself is created
before we make the "anti-aliased or not" choice.
(nautilus_icon_factory_get_icon_for_file): Since we no longer know
whether the icon will be needed anti-aliased or not, make the
thumbnail code always use the anti-aliased version (and added
FIXME). Also changed the "loading" image to use the normal icon
name case instead of hard-coding.
(nautilus_icon_factory_get_emblem_icon_by_name): Removed the
anti-aliased parameter.
(nautilus_icon_factory_get_emblem_icons_for_file): Removed the
anti-aliased parameter.
(load_specific_icon): Add an anti-aliased parameter.
(load_icon_for_scaling): Add an anti-aliased parameter.
(load_icon_scale_if_necessary): Pass in the anti-aliased parameter
from the icon size request.
(get_icon_from_cache): Pass in the anti-aliased parameter from the
icon size request.
(nautilus_icon_factory_get_pixbuf_for_icon): Add an anti-aliased
parameter.
(cache_key_hash): Include the anti-aliased flag in the hash.
(cache_key_equal): Include the anti-aliased flag in the compare.
(nautilus_icon_factory_get_pixbuf_for_file): Pass the anti-aliased
parameter into the get_pixbuf half, not the get_icon_for_file
half.
(nautilus_icon_factory_get_pixbuf_from_name): Pass the
anti-aliased parameter into the get_pixbuf half, not the
scalable_icon_new half.
(load_icon_with_embedded_text): Remove the anti-aliased parameter.
* src/file-manager/fm-icon-view.c: (get_icon_images_callback): Get
rid of code to pass in the anti-aliased parameter.
* src/file-manager/fm-list-view.c:
(fm_list_view_get_emblem_pixbufs_for_file): Pass the anti-aliased
parameter to the pixbuf-getting function, not the
scalable-icon-getting part.
* src/nautilus-bookmark-parsing.c:
(nautilus_bookmark_new_from_node): No need to pass an anti-aliased
parameter (before it was always FALSE).
* src/nautilus-sidebar-title.c: (update_emblems): Pass FALSE for
the anti-aliased parameter to the get_pixbuf call rather than to
the get_icons call.
* src/nautilus-window-manage-views.c: (get_history_list_callback):
No need to pass FALSE for anti-aliased any more.
* src/nautilus-window-menus.c: (append_bookmark_to_menu): No need
to pass FALSE for anti-aliased any more.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also reduced the number of times that refresh_bookmarks_menu
is called since it was showing up in some profiling.
* libnautilus-extensions/nautilus-bookmark.h:
* libnautilus-extensions/nautilus-bookmark.c:
(nautilus_bookmark_initialize_class), (nautilus_bookmark_set_name),
(bookmark_file_changed_callback): Split the "changed" signal into
"appearance_changed" and "content_changed". "appearance_changed" is
emitted only if the name or icon change. "content_changed" is emitted
if the URI changes.
* src/nautilus-bookmark-list.c: (insert_bookmark_internal):
Connect to both appearance_changed and content_changed.
* src/nautilus-window-menus.c: (bookmark_holder_new):
Refresh menu only on appearance_changed, not content_changed.
* data/static_bookmarks.xml: Added "i-web" as icon name for
all the built-in bookmarks, since this is the icon they will
end up with after being visited. (Now, visiting a built-in
bookmark will not cause a refresh of the bookmarks menu.)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also changed a few places to compare uris with the new
nautilus_uris_match instead of strcmp.
* libnautilus-extensions/nautilus-bookmark.h,
* libnautilus-extensions/nautilus-bookmark.c:
(nautilus_bookmark_compare_with): Use nautilus_uris_match.
(nautilus_bookmark_compare_uris): New function, compares
bookmarks' uris with nautilus_uris_match; ignores names.
* src/nautilus-window-manage-views.c:
(nautilus_window_set_displayed_location), (handle_go_elsewhere),
(open_location): Use nautilus_uris_match.
* src/nautilus-window.c: (nautilus_add_to_history_list):
Use nautilus_bookmark_compare_uris instead of _compare_with.
This was the source of the bug. Due to asynchronicity introduced
sometime after this code was written, when the bookmark for the
current location was created it did not yet know what name to use,
and so it did not match any of the old History items that had the
correct name. But for the History list we only want one entry per
uri anyway, so it needn't have been comparing the names in the
first place.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
an icon). I picked arbitrary existing icons (gnome foot
for "generic bookmark", gnome-foot-question-mark for
"bookmark with known-bad URI"); Arlo and/or Susan will
have to come up with real ones. I'll write a separate
bug report about that.
* icons/i-bookmark.png:
* icons/i-bookmark-20.png:
* icons/i-bookmark-missing.png:
* icons/i-bookmark-missing-20.png: New icons to use
for bookmarks. I supplied the base size and the 20
pixel size because that's the one used in menus, where
bookmarks usually appear. These need to be replaced with
better images.
* icons/Makefile.am: Add new icons to installed set.
* libnautilus-extensions/nautilus-bookmark.h,
* libnautilus-extensions/nautilus-bookmark.c:
(nautilus_bookmark_uri_known_not_to_exist): New public
function, moved some code from elsewhere to encapsulate this.
(nautilus_bookmark_set_icon_to_default): Choose between the
generic and bad-URI icon if there's no better icon.
* src/nautilus-window-menus.c: (activate_bookmark_in_menu_item):
Now calls nautilus_bookmark_uri_known_not_to_exist instead
of doing the work here.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
You can avoid some warnings if you get the latest Bonobo.
* libnautilus-extensions/nautilus-bookmark.h:
* libnautilus-extensions/nautilus-bookmark.c:
(nautilus_bookmark_initialize_class), (nautilus_bookmark_set_name):
Define "changed" signal for bookmarks and wire it up (though
not yet to the icon-changing case). Remove never-implemented
and never-to-be-implemented "nautilus_bookmark_get_file" since
I changed my mind on the design.
* src/nautilus-window-menus.c: (append_bookmark_to_menu),
(clear_appended_bookmark_items): Connect and disconnect
signals from the window to the bookmarks in the Go and
Bookmarks menus.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
No visible effect yet.
* libnautilus-extensions/nautilus-bookmark.h:
Added nautilus_bookmark_get_file prototype, not yet
called or implemented.
* libnautilus-extensions/nautilus-file.h,
* libnautilus-extensions/nautilus-file.c:
(nautilus_file_check_if_ready): New function, does
nothing yet.
* libnautilus-extensions/nautilus-icon-factory.h:
Added nautilus_icon_factory_is_icon_ready_for_file
prototype, not yet called or implemented.
* src/nautilus-window-menus.c:
(nautilus_window_initialize_bookmarks_menu),
(nautilus_window_initialize_go_menu),
(nautilus_window_remove_bookmarks_menu_callback),
(nautilus_window_remove_go_menu_callback),
(refresh_bookmarks_menu),
(refresh_bookmarks_menu_idle_callback),
(schedule_refresh_bookmarks_menu), (refresh_go_menu),
(refresh_go_menu_idle_callback), (schedule_refresh_go_menu):
Made the code that rebuilds the Go and Bookmarks menus when
there's been a change to the bookmarks use idle handling to
batch up requests. This will be important when bookmarks
broadcast updates for their icons.
* src/nautilus-window-private.h: Defined NautilusWindowDetails
struct. We should eventually migrate all of the fields
of NautilusWindow in here, but I didn't do that now.
Added two fields used by bookmark-menu-updating code.
* src/nautilus-window.h: Made a details field using
NautilusWindowDetails.
* src/nautilus-window.c:
(nautilus_window_init): Create details field.
(nautilus_window_destroy): Clean up any pending idle bookmark
refreshing stuff.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in the dark ages (by me).
* libnautilus-extensions/nautilus-bookmark.c:
(nautilus_bookmark_compare_with), (nautilus_bookmark_copy),
(nautilus_bookmark_get_name),
(nautilus_bookmark_get_pixmap_and_mask),
(nautilus_bookmark_get_pixbuf), (nautilus_bookmark_get_icon),
(nautilus_bookmark_get_uri), (create_pixmap_widget_for_bookmark),
(nautilus_bookmark_menu_item_new): Eliminated the use of
const NautilusBookmark *; made _get_name and _get_uri return
copies instead of the original text; tweaked a little formatting.
* components/history/nautilus-history-view.c: (install_icon),
(hyperbola_navigation_history_load_location),
(hyperbola_navigation_history_select_row):
* libnautilus-extensions/nautilus-bookmark.h:
* src/nautilus-bookmark-list.c: (append_bookmark_node),
(nautilus_bookmark_list_append), (nautilus_bookmark_list_contains),
(nautilus_bookmark_list_delete_items_with_uri),
(nautilus_bookmark_list_insert_item):
* src/nautilus-bookmark-list.h:
* src/nautilus-bookmarks-window.c: (install_bookmark_icon),
(on_select_row), (repopulate):
* src/nautilus-window-manage-views.c:
(nautilus_window_reset_title_internal), (handle_go_back),
(handle_go_forward), (handle_go_elsewhere):
* src/nautilus-window-menus.c: (bookmark_holder_new),
(show_bogus_bookmark_window), (activate_bookmark_in_menu_item),
(append_bookmark_to_menu),
(nautilus_window_add_bookmark_for_current_location):
* src/nautilus-window.c: (nautilus_window_back_or_forward):
Eliminated the use of const NautilusBookmark *; changed all
callers of nautilus_bookmark_get_name and _get_uri to free
the results.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
each remote bookmark). Bookmarks now get their icon only
when they're initially created, and then store a text
version of it to disk for future sessions. We might have
to update the icon at certain times later (maybe when it's
used?).
* libnautilus-extensions/nautilus-bookmark.h,
* libnautilus-extensions/nautilus-bookmark.c:
(nautilus_bookmark_copy), (nautilus_bookmark_get_pixbuf),
(nautilus_bookmark_get_icon), (get_icon_for_uri),
(nautilus_bookmark_new), (nautilus_bookmark_new_with_icon):
Changed guts of NautilusBookmark to keep a
NautilusScalableIcon around. Also some miscellaneous
cleanup in this ancient file (need to do more).
* libnautilus-extensions/nautilus-icon-factory.h,
* libnautilus-extensions/nautilus-icon-factory.c:
(get_themed_icon_file_path): Added icon != NULL assert.
(get_icon_file_path): Handle NULL icon name by returning NULL;
some style fixes.
(nautilus_scalable_icon_get_text_pieces): New function,
returns all four pieces of text used to define a
NautilusScalableIcon.
(nautilus_scalable_icon_new_from_text_pieces):
Renamed from nautilus_scalable_icon_get and made public.
(nautilus_icon_factory_get_icon_for_file),
(nautilus_icon_factory_get_emblem_icon_by_name),
(load_image_with_embedded_text): Updated for function renaming.
* src/nautilus-bookmark-list.c: (append_bookmark_node),
(make_bookmark_from_node), (nautilus_bookmark_list_load_file):
Save & restore NautilusScalableIcon with each bookmark.
Added custom error message when trying to open a location
fails with GNOME_VFS_LOGINFAILED
* src/nautilus-applicable-views.h: Define
NAUTILUS_NAVIGATION_RESULT_LOGIN_FAILED
* src/nautilus-applicable-views.c:
(get_nautilus_navigation_result_from_gnome_vfs_result):
Support GNOME_VFS_LOGINFAILED, and tweak message for
unhandled case.
* src/nautilus-window-manage-views.c:
(nautilus_window_end_location_change_callback):
Support NAUTILUS_NAVIGATION_RESULT_LOGIN_FAILED and
remove message for unhandled case since complaining
about unhandled cases is done elsewhere.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bugs for the FIXME items but we were distracted into fixing bugs
and tweaking code that we found while doing so.
* check-FIXME.pl: Won't search old ChangeLogs for FIXMEs either;
changed FIXME format from "FIXME bug xxx" to "FIXME bugzilla.eazel.com xxx"
* components/history/ntl-history-view.c:
(hyperbola_navigation_history_notify_location_change): Moved bookmark
naming hack here and added FIXME explaining it.
* libnautilus-extensions/nautilus-bookmark.h,
* libnautilus-extensions/nautilus-bookmark.c:
(nautilus_bookmark_new), (nautilus_bookmark_new_with_name):
Combined these two into one routine that takes both the uri and
title; removed hack for trying to come up with good name for
bookmark here.
(nautilus_bookmark_get_pixmap_and_mask): Changed to call
_get_pixbuf instead of duplicating code.
(nautilus_bookmark_get_pixbuf): Changed interface to return
pixbuf or NULL instead of boolean result & "out" parameter.
* src/nautilus-bookmark-list.c,
* src/nautilus-bookmarks-window.c,
* src/nautilus-window-menus.c,
* src/ntl-window-msgs.c:
Updated callers of nautilus_bookmark_new and _new_with_name.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* libnautilus-extensions/nautilus-string.c:
* libnautilus-extensions/nautilus-string.h:
After a chat with Rebecca, named nautilus_str_underscore_escape to
nautilus_str_double_underscores since the latter name more
accurately describes what it does.
(nautilus_str_double_underscores): Changed the function to allow
NULL and return NULL instead of doing g_return_val_if_fail.
(Also reformatted a bit and made a few gratuitous changes.)
* libnautilus-extensions/nautilus-bookmark.c:
* libnautilus-extensions/nautilus-bookmark.h:
(nautilus_bookmark_get_menu_display_name):
Moved the logic about escaping menu characters up one level so
the bookmark class doesn't have to know about it. This removes
the function from NautilusBookmark completely.
* src/nautilus-window-menus.c:
(append_bookmark_to_menu): Fixed a storage leak and moved the
double-underscore escaping in here.
|
| |
|
|
|
|
| |
Created new function, to display bookmark names in menu in
nautilus-bookmark,
and new string function to double underscores in nautilus-string
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2000-04-11 Gene Z. Ragan <gzr@eazel.com>
* components/sample/nautilus-sample-content-view.c
Added icon data to BonoboUiHandler. This is GdkPixbuf
data and demonstrates the pixbuf data features
added to bonobo ui handlers.
* libnautilus/nautilus-bookmark.c
bonobo_ui_handler_menu_new_item modified to take advantage
of new bonobo ui handler pixbuf functionality. Components and
menu items can now display pixbuf data.
Added nautilus_bookmark_get_pixbuf() routine.
* libnautilus/nautilus-bookmark.h
Added nautilus_bookmark_get_pixbuf() routine.
* src/nautilus-window-menus.c
bonobo_ui_handler_menu_new_item modified to take advantage
of new bonobo ui handler pixbuf functionality.
|
| |
|
|
|
|
| |
location; this is used initially (and most importantly) by web pages so that
bookmarks, the window title, and the index panel will display the html page title
rather than the url.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* HACKING: Tell people about the gnome-xml branch.
* libnautilus/Makefile.am:
* libnautilus/gnome-icon-container-grid.c:
* libnautilus/gnome-icon-container-grid.h:
* libnautilus/gnome-icon-container-private.h:
* libnautilus/gnome-icon-container.c:
Broke out the grid code from the main container code.
This is a first step toward improving the layout code.
* libnautilus/nautilus-directory-private.h:
* libnautilus/nautilus-directory.c:
* libnautilus/nautilus-directory.h:
* src/fm-directory-view.c:
Got started on making the directory I/O async.
There's still a long way to go, this was a baby step.
* libnautilus/nautilus-bookmark.c:
* libnautilus/nautilus-bookmark.h:
* libnautilus/nautilus-self-checks.c:
General cleanup.
* libnautilus/nautilus-file.h:
Rearranged a little bit.
* libnautilus/nautilus-file-utilities.c:
Put FIXME in where there's code that needs to be changed.
|
| |
|
|
| |
made history items appear in Go menu.
|
|
|
History metaview.
|
