| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nautilus fails to create an archive if one of the folders selected
cannot be read, despite selecting "Skip".
This is because the compress operation does not use skip_files, which
was populated by scan_sources.
Remove source_files nodes if they should be skipped before passing the
linked list to AutoarCompressor.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2928
|
|
|
|
|
|
|
| |
This change replaces the tooltips of the "Select Dates" and "Anything" dropdown menus with a11y labels,
as suggested in https://gitlab.gnome.org/GNOME/nautilus/-/issues/2754#note_1626144
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2754
|
|
|
|
|
|
|
|
| |
This change applies header capitalization to some tooltips to follow HIG.
https://developer.gnome.org/hig/patterns/feedback/tooltips.html
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2754
|
|
|
|
|
|
|
|
| |
HIG advises that tooltip must be short, so this change shorten the text of some tooltips.
https://developer.gnome.org/hig/patterns/feedback/tooltips.html
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2754
|
|
|
|
|
|
|
|
| |
Acc. HIG, all controls from headerbars must have a tooltip.
https://developer.gnome.org/hig/patterns/feedback/tooltips.html
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2754
|
|
|
|
|
| |
Display proper shortcuts arrow directions in the shortcuts
window for navigation and tree view expand/collapse.
|
|
|
|
|
|
| |
Change the direction of forward and backward history
navigation arrow shortcuts based on the text direction of
the application.
|
|
|
|
| |
(cherry picked from commit ec4f11d78761d50ce1fdfd6a8d530bc3a75a4ce3)
|
|
|
|
| |
This is required for GtkColumnViewCell that was added in
93a714df.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of selecting a row and moving it with up/down buttons, add a
menu to each row, that allows moving the row up and down. This gives the
per-folder switch in the bottom bar more space and allows the rows to be
activatable.
The moving menu is implemented using actions. To keep track of which
row the action is called for, store the row for which the menu is
opened via a GtkMenuButtonCreatePopupFunc callback.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
When a folder has custom columns (i.e. the file metadata is set),
then show a banner saying there are custom columns, with a button to
reset to default. If there aren't custom columns, then there won't be
a banner, and instead there will be a switch to allow setting the
columns as custom for the folder instead of default.
Default columns should only be updated on "close" for the window to
prevent user confusion.
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's this complicated back and forth between the listview and
the column chooser. Work happens in both and it gets confusing
and creates unnecessary complexity. It also will cause problems
in a future commit where we may want to revert changes that were
made but the list-view doesn't know about that.
Have the column-chooser load in all of the information, and set
the information. The list-view is merely notified of the changes
for display purposes.
|
| |
|
| |
|
|
|
|
| |
These will be implemented in a later commit
|
|
|
|
|
|
|
|
|
|
| |
We were subclassing from GtkBox and then, list-view created a
list-view-column-editor which subclassed from AdwWindow to add
the column-chooser. It's a lot of extra code / complexity for something
that is only used in list-view. This also allows us to directly
use column-chooser within list-view.
Also drop the list description label, in preparation for the switch to GtkListBox.
|
|
|
|
|
|
|
|
|
| |
This bug has been around since the function was added over 12 years
ago. Fortunately, it doesn't have any noticeable impacts. But we are
about to change the parent class to AdwWindow, which needs to run its
own .constructed(), so let's chain up in preparation.
See: 4b3038b4ea85ce309d6fb128675611d3c912739e
|
|
|
|
|
| |
Add a private property that is meant to help that column chooser
know if the nautilus-column should be visible or not.
|
|
|
|
| |
Use action-name properties to avoid repeating shortcut assignments.
|
|
|
|
| |
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2882
|
|
|
|
|
|
|
|
| |
The ci template was changed to run-tests during the build which
causes our pipelines to fail. Revert to a previous ci template
until this is sorted out
See: https://gitlab.gnome.org/GNOME/citemplates/-/merge_requests/37
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
This doesn't give us anything currently, but it's the direction that
GtkColumnView is going in, so let's use it. Some minor modifications
are necessary to list-base where GridView and ColumnView share code.
|
|
|
|
|
|
|
|
|
|
|
|
| |
When moving multiple files to trash, the toast currently
says: "%d files deleted". However, "deleted" implies permanent
loss of data. But, in this case, we are just moving files to the trash.
This commit corrects the string to show the actual action:
"%d files moved to trash".
Also correct Translators comments to make it consistent with the action.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2830
|
|
|
|
|
|
|
|
|
|
| |
Using the same icon as for closing windows and dialogs can lead to user
confusion and thus accidental cancellation of operations.
This adds and uses a new icon, inspired by Builder's use of it to stop
ongoing operations.
Fixes #985
|
| |
|
|
|
|
|
|
|
|
| |
The `NautilusFreedesktopDBus` class has a `connection` property, which
is not needed anymore after the commit 765b4d24. Let's drop that property
now. This effectively reverts a big part of commit 2293e813.
Related: https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/1134
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The callback function in delete_files_recursively() uses the results
from its GError to determine if it should call
nautilus_file_changes_queue_file_removed() (which ultimately calls the
list-base remove_file() function).
This normally, works as expected, except when one of the child
files fails to delete. We check for recursive deletion failures, but
we never get the error that caused that failure. This means that the
callback function will believe that the parent folder was deleted
(when it really wasn't), and the item will disappear from the view in
Nautilus because of the call to nautilus_file_changes_queue_file_removed().
If we weren't successful at deleting, but there's no error, that means
that a recursive call to delete failed. In that case let's generate
our own error.
Fixes: #517
|
| |
|
| |
|
| |
|
|
|
|
| |
Pass new uncrustify criteria. No logic changes.
|
|
|
| |
Adapted from gnome-software
|
|
|
|
| |
Part of https://gitlab.gnome.org/GNOME/nautilus/-/issues/2678
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It includes the GTK bugfix mentioned in 2e10ed11d960cb6343719d680e29d742dc86d664
As we have removed the workaround, we cannot accept a GTK
version without that bugfix, because that would cause a
regression.
And we can't restore the workaround either, because it
misbehaves when using the fixed GTK version.
This leaves us with no other choice than requiring the
fixed GTK version.
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 9ecd422cc78efad939d072e61c13e1c3a7726fc9.
Its commit message is misleading. Maybe it had such a side effect,
but the issue it fixed was actually a GTK bug which got fixed in the
meantime: https://gitlab.gnome.org/GNOME/gtk/-/commit/8455b9ac74d5337429a1a14eb>
Also, reverting it fixes a new bug: the first item is selected when
the item which was selected has been deleted. Next item should be
selected instead.
|
|
|
|
|
|
|
|
| |
In 098f6a43d782e7791caa4c443f6ab08a1310f4a0 the style was changed from
dim-label to caption. For consistency with list-view columns and to have
less visual noise, add the dim-label style class back.
Fixes #2876
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
At some point, the flatpak command line interface changed so it is not
possible to add multiple values to a same key with a single --add-policy
call. Doing this now results in a single value added, with the ';'
escaped, this breaks Tracker portal access and results in Nautilus resorting
to the built-in miner instance.
It is however possible to call --add-policy multiple times to make
a multi-valued key, this restores the intended behavior and provides
access to the two tracker:FileSystem and tracker:Documents graphs.
Adapt the flatpak manifest to do this.
Closes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2838
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We present a new toast every time the undo action changed which
is confusing because you might have several undo toasts appearing
over each other. To complicate matters, the previous undo toasts
lie (undo'ing would actually undo a different action).
There was a proposal in #2350 to batch undo toasts, but that's problematic
because our undo manager is designed to undo exactly 1 action,
we do not have an undo stack.
The more straightforward solution seems to be simply dismissing the
old undo toasts, when we popup a new undo toast.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2350
|
|
|
|
|
|
|
|
|
|
| |
Whenever g_time_zone_new_local() is called it has to check the file
system for changes, because the system's time zone might have changed
since the last call. This function was called multiple times for each
file when generating the date string, which was causing some unnecessary
overhead.
This changes the code to re-use the local time zone from the first call.
|
| |
|
|
|
|
|
| |
Use g_set_object to simplify setter logic and avoid issues if
current_location == location.
|