diff options
| author | Michaël Zasso <targos@protonmail.com> | 2022-09-21 15:47:37 +0200 |
|---|---|---|
| committer | Node.js GitHub Bot <github-bot@iojs.org> | 2023-03-31 14:15:28 +0000 |
| commit | 6f5655a18e51f739b382cc99083156ac3f9724c3 (patch) | |
| tree | 7feacbd64bbbe7af0aa4f7a7df2357b5e2605479 /deps | |
| parent | 295b2f3ff45650ee3f47869417bb546af44e76b7 (diff) | |
| download | node-new-6f5655a18e51f739b382cc99083156ac3f9724c3.tar.gz | |
deps: always define V8_EXPORT_PRIVATE as no-op
dllexport introduces issues when compiling with MSVC.
PR-URL: https://github.com/nodejs/node/pull/47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Diffstat (limited to 'deps')
| -rw-r--r-- | deps/v8/src/base/macros.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/deps/v8/src/base/macros.h b/deps/v8/src/base/macros.h index cd5b91f745..c267b8f1e9 100644 --- a/deps/v8/src/base/macros.h +++ b/deps/v8/src/base/macros.h @@ -389,9 +389,9 @@ bool is_inbounds(float_t v) { // Setup for Windows shared library export. #ifdef BUILDING_V8_SHARED -#define V8_EXPORT_PRIVATE __declspec(dllexport) +#define V8_EXPORT_PRIVATE #elif USING_V8_SHARED -#define V8_EXPORT_PRIVATE __declspec(dllimport) +#define V8_EXPORT_PRIVATE #else #define V8_EXPORT_PRIVATE #endif // BUILDING_V8_SHARED @@ -401,7 +401,7 @@ bool is_inbounds(float_t v) { // Setup for Linux shared library export. #if V8_HAS_ATTRIBUTE_VISIBILITY #ifdef BUILDING_V8_SHARED -#define V8_EXPORT_PRIVATE __attribute__((visibility("default"))) +#define V8_EXPORT_PRIVATE #else #define V8_EXPORT_PRIVATE #endif |