diff options
author | Luigi Pinca <luigipinca@gmail.com> | 2018-03-27 19:35:03 +0200 |
---|---|---|
committer | Luigi Pinca <luigipinca@gmail.com> | 2018-03-29 12:55:00 +0200 |
commit | 37db277bb4f7fe9a00e728b91f354b62b3c279ce (patch) | |
tree | ef714f28a01715c2decb89f0244d60450b69f034 /test/parallel/test-net-dns-error.js | |
parent | a34f1e32453951d026a3b58a30b83df065060612 (diff) | |
download | node-new-37db277bb4f7fe9a00e728b91f354b62b3c279ce.tar.gz |
test: refactor test-net-dns-error
- Use `common.mustCall()` and `common.mustNotCall()`.
- Use ternary operator.
PR-URL: https://github.com/nodejs/node/pull/19640
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/parallel/test-net-dns-error.js')
-rw-r--r-- | test/parallel/test-net-dns-error.js | 17 |
1 files changed, 5 insertions, 12 deletions
diff --git a/test/parallel/test-net-dns-error.js b/test/parallel/test-net-dns-error.js index a5ae415592..0d943bf6cd 100644 --- a/test/parallel/test-net-dns-error.js +++ b/test/parallel/test-net-dns-error.js @@ -21,27 +21,20 @@ 'use strict'; const common = require('../common'); -const assert = require('assert'); +const assert = require('assert'); const net = require('net'); const host = '*'.repeat(256); +const errCode = common.isOpenBSD ? 'EAI_FAIL' : 'ENOTFOUND'; -let errCode = 'ENOTFOUND'; -if (common.isOpenBSD) - errCode = 'EAI_FAIL'; - -function do_not_call() { - throw new Error('This function should not have been called.'); -} - -const socket = net.connect(42, host, do_not_call); +const socket = net.connect(42, host, common.mustNotCall()); socket.on('error', common.mustCall(function(err) { assert.strictEqual(err.code, errCode); })); -socket.on('lookup', function(err, ip, type) { +socket.on('lookup', common.mustCall(function(err, ip, type) { assert(err instanceof Error); assert.strictEqual(err.code, errCode); assert.strictEqual(ip, undefined); assert.strictEqual(type, undefined); -}); +})); |