summaryrefslogtreecommitdiff
path: root/BUILDING.md
Commit message (Collapse)AuthorAgeFilesLines
* doc: update supported version of FreeBSD to 12.4Michaël Zasso2023-05-061-1/+1
| | | | | | | Refs: https://github.com/nodejs/build/issues/3134 PR-URL: https://github.com/nodejs/node/pull/47838 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* doc: update BUILDING.md previous versions linksTobias Nießen2023-05-031-3/+2
| | | | | | | | | | | Remove EOL release lines and add missing supported release lines. PR-URL: https://github.com/nodejs/node/pull/47835 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
* doc: fix capitalization of ASanMohammed Keyvanzadeh2023-04-231-5/+5
| | | | | PR-URL: https://github.com/nodejs/node/pull/47676 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
* doc: update darwin-x64 toolchain used for Node.js 20 releasesMichaël Zasso2023-04-141-2/+2
| | | | | | | Refs: https://github.com/nodejs/node/issues/47067 PR-URL: https://github.com/nodejs/node/pull/47546 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
* doc: update toolchains used for Node.js 20 releasesRichard Lau2023-04-031-12/+17
| | | | | | | | | | | | | Update the table describing the platform and toolchain used to build the official Node.js 20 binaries. PR-URL: https://github.com/nodejs/node/pull/47352 Refs: https://github.com/orgs/nodejs/discussions/45892 Refs: https://github.com/nodejs/node/issues/47067 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
* doc: make win arm64 tier 2 platformStefan Stojanovic2023-03-301-1/+1
| | | | | | | | | Refs: https://github.com/nodejs/build/issues/3046 Refs: https://github.com/nodejs/build/issues/2540 Fixes: https://github.com/nodejs/node/issues/25998 PR-URL: https://github.com/nodejs/node/pull/47233 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* msi: migrate to WiX4Stefan Stojanovic2023-03-221-4/+1
| | | | | | | | | To be able to build x86, x64, and ARM64 MSI installers with the same WiX version, migration to WiX4 is required. PR-URL: https://github.com/nodejs/node/pull/45943 Refs: https://github.com/nodejs/build/issues/2540 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* build: warn for gcc versions earlier than 10.1Richard Lau2023-02-251-2/+2
| | | | | | | | | | | | | | | Update the warning threshold for gcc to 10.1 starting from Node.js 20. Builds can still proceed with earlier versions of gcc, but are not guaranteed to work. PR-URL: https://github.com/nodejs/node/pull/46806 Refs: https://github.com/nodejs/node/discussions/45892 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* doc: enrich test command with executableTony Gorez2023-02-061-1/+6
| | | | | | PR-URL: https://github.com/nodejs/node/pull/44347 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* build: support Python 3.11Luigi Pinca2022-10-281-3/+3
| | | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/45191 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
* src: add support for externally shared js builtinsMichael Dawson2022-10-111-0/+38
| | | | | | | | | | | | | | | | | Refs: https://github.com/nodejs/node/issues/44000 - add infra to support externally shared js builtins in support of distos that want to externalize deps that include JS/WASM instead of native code - add support for externalizing - cjs_module_lexer/lexer - cjs_module_lexer/dist/lexer - undici/undici Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/44376 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
* doc: improve building doc for AndroidBuShe Pie2022-10-101-1/+1
| | | | | | PR-URL: https://github.com/nodejs/node/pull/44888 Refs: https://github.com/nodejs/node/pull/44207 Reviewed-By: Feng Yu <F3n67u@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* doc: improve building doc for Windows PowershellBrian Muenzenmeyer2022-09-161-0/+1
| | | | | | PR-URL: https://github.com/nodejs/node/pull/44625 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
* doc: improved building doc for AndroidBuShe2022-08-121-5/+8
| | | | | PR-URL: https://github.com/nodejs/node/pull/44166 Reviewed-By: Feng Yu <F3n67u@outlook.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
* doc: fix Visual Studio 2019 download linkFeng Yu2022-06-211-2/+2
| | | | PR-URL: https://github.com/nodejs/node/pull/43236 Reviewed-By: Michaël Zasso <targos@protonmail.com>
* doc: fix 404 link of BUILDING.mdFeng Yu2022-06-021-1/+1
| | | | | PR-URL: https://github.com/nodejs/node/pull/43234 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* src,deps,build,test: add OpenSSL config appnameDaniel Bevenius2022-05-311-0/+17
| | | | | | | | | | | | | | | | | | | | This commit adds the setting of an appname (configuration section name), 'nodejs_conf', to be used when reading OpenSSL configuration files. The motivation for this is that currently the default OpenSSL configuration, 'openssl_conf', element will be used which may be undesirable as it might configure OpenSSL in unwanted ways. With this commit it is still possible to use a default openssl.cnf file but the only section that Node.js will read from is a section named 'nodejs_conf'. PR-URL: https://github.com/nodejs/node/pull/43124 Refs: https://github.com/nodejs/node/issues/40366 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
* doc: make minor adjustmentsLivia Medeiros2022-05-241-1/+1
| | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/43175 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
* doc: reword "test directory"LiviaMedeiros2022-04-281-1/+2
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42817 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* doc: remove legacy `-J` test.py option from BUILDING.mdLiviaMedeiros2022-04-281-2/+2
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42817 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* Revert "build: make x86 Windows support temporarily experimental"Michaël Zasso2022-04-211-22/+23
| | | | | | | | This reverts commit 35d72bf4ec8369c1dbfb65b655cdb160366587f5. PR-URL: https://github.com/nodejs/node/pull/42740 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* doc: update minimum glibc requirements for LinuxRichard Lau2022-04-131-47/+36
| | | | | | | | | | | | | | | | | | | Starting with Node.js 18 we have moved building the release binaries from being built on CentOS 7/RHEL 7 to being built on RHEL 8 as the End-of-Life date of CentOS 7/RHEL 7 is before the End-of-Life date of Node.js 18 and we do not want to have to make a disruptive change towards the end of Node.js 18's life cycle. Moving to RHEL 8 has raised the glibc version being linked against (2.28). The official Node.js Linux release binaries will only run on Linux distributions with a matching or higher version of glibc. PR-URL: https://github.com/nodejs/node/pull/42659 Refs: https://github.com/nodejs/build/issues/2815 Refs: https://github.com/nodejs/build/issues/2741 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* build: make x86 Windows support temporarily experimentalMichaël Zasso2022-04-121-23/+22
| | | | | | | | | | | | | | | We currently have no solution to build Node.js for x86 Windows with V8 10.1. V8 10.2 seems fixed, but that version won't stable enough by the time we release Node.js 18.0.0 (it only has canary coverage). The goal is to revert this commit as soon as the issue is fixed. PR-URL: https://github.com/nodejs/node/pull/42666 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
* doc: update AIX minimum supported archRichard Lau2022-04-071-1/+1
| | | | | | | | | | | | | | | Raise the minimum supported arch for AIX to Power 8 in line with the existing minimum supported Power arch for Linux. We do not have anything earlier than Power 8 in our CI so are unable to test on it, and have reached out to IBM who have no concerns over baselining on Power 8 for Node.js 18. PR-URL: https://github.com/nodejs/node/pull/42604 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* build: bump macOS deployment target to 10.15Richard Lau2022-03-181-5/+4
| | | | | | | | | | | | | | | | | Update the macOS deployment target for Node.js 18 onwards. PR-URL: https://github.com/nodejs/node/pull/42292 Refs: https://github.com/nodejs/build/issues/2815 Refs: https://github.com/libuv/libuv/pull/3406 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Ash Cripps <acripps@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* build: downgrade Windows 8.1 and server 2012 R2 to experimentalMichaël Zasso2022-03-071-3/+3
| | | | | | | | | | | | | | | | | | Both versions will be end of life in 2023, before the end of Node.js 18. Refs: https://docs.microsoft.com/en-us/lifecycle/products/windows-81 Refs: https://docs.microsoft.com/en-us/lifecycle/products/windows-server-2012-r2 PR-URL: https://github.com/nodejs/node/pull/42105 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* doc: make building with ninja more discoverableBalakrishna Avulapati2022-02-251-0/+4
| | | | | | | | | | | | | Building with ninja would speed up the build We have the documenation about building with ninja, but not easily discoverable. And present this early to the contributors. PR-URL: https://github.com/nodejs/node/pull/41840 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
* doc: add 16 and 17 to previous versionsAntoine du Hamel2022-01-221-1/+2
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/41646 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* doc: document support building with Python 3.10 on WindowsChristian Clauss2021-12-101-1/+1
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/41098 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
* doc: add note about pip being requiredPiotr Rybak2021-12-101-6/+8
| | | | | | | | | Clean install requires pip to make coverage but instructions didn't mention it. PR-URL: https://github.com/nodejs/node/pull/40669 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* doc: remove legacy -J test.py option from BUILDING.mdRich Trott2021-11-271-1/+1
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/40945 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* doc: update BUILDING.md section on running testsRich Trott2021-11-251-15/+17
| | | | | | | | Refs: https://github.com/nodejs/node/issues/40920 PR-URL: https://github.com/nodejs/node/pull/40933 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* tools: avoid unnecessary escaping in markdown formatterRich Trott2021-10-311-2/+2
| | | | | | | | | Update mdast-util-to-markdown to 1.2.4 which reduces unnecessary escaping of `_` and some other characters. Re-run markdown formatter. PR-URL: https://github.com/nodejs/node/pull/40645 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* doc: simplify ccache instructionsRich Trott2021-10-241-12/+8
| | | | | | | | | | | | | `ccache` has reasonable defaults for `max_size` and `cache_dir` so remove instructions to set those things explicitly. Change fenced code from `console` to `bash` for easier copy/paste. PR-URL: https://github.com/nodejs/node/pull/40550 Fixes: https://github.com/nodejs/node/issues/40542 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* doc: fix macOS environment variables for ccacheRich Trott2021-10-241-0/+12
| | | | | | | | | | | | macOS requires `cc` and `c++` rather than `gcc` and `g++`. Closes: https://github.com/nodejs/node/issues/40542 PR-URL: https://github.com/nodejs/node/pull/40550 Fixes: https://github.com/nodejs/node/issues/40542 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* doc: use GFM footnotes in BUILDING.mdRich Trott2021-10-221-65/+73
| | | | | PR-URL: https://github.com/nodejs/node/pull/40474 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* deps,test,src,doc,tools: update to OpenSSL 3.0Daniel Bevenius2021-10-111-5/+42
| | | | | | | | | | | | | | | | This pull request updates the OpenSSL version that is statically linked with Node.js from OpenSSl 1.1.1 to quictls OpenSSL 3.0.0+quic. This pull request will replace the OpenSSL version that is currently in the deps directory and when performing a normal build OpenSSL 3.0+quic will be statically linked to the Node.js executable. We will still be able to dynamically link to OpenSSL 1.1.1 and we have a CI job which dynamically links to OpenSSL 1.1.1 which is run for every pull request to make sure that we maintain backward compatibility. PR-URL: https://github.com/nodejs/node/pull/38512 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* doc: format general markdown filesRich Trott2021-10-061-22/+22
| | | | | | | | | Use `make format-md` to format general markdown files. PR-URL: https://github.com/nodejs/node/pull/40322 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* build: support Python 3.10.0FrankQiu2021-10-061-2/+2
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/40296 Fixes: https://github.com/nodejs/node/issues/40294 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* doc: update minimum supported FreeBSD to 12.2Michaël Zasso2021-09-251-7/+3
| | | | | | | | | | | FreeBSD 11 goes out of support on 2021-09-30. FreeBSD 12.1 is not supported since 2021-01-31. PR-URL: https://github.com/nodejs/node/pull/40179 Refs: https://en.wikipedia.org/wiki/FreeBSD_version_history#Version_history Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* doc: update markdown formatting for *.md filesRich Trott2021-09-211-25/+44
| | | | | | | | | | | Fix formatting that will change when run through upcoming remark preset. PR-URL: https://github.com/nodejs/node/pull/40154 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
* doc: update min mac ver + move mac arm64 to tier 1Ash Cripps2021-08-011-2/+6
| | | | | | | | | | | | | | | | | Update the minimum macos version that can compile to match the xcode requirements. Also move mac arm64 to tier 1. refs: https://github.com/nodejs/node/issues/39584#issuecomment-889701855 PR-URL: https://github.com/nodejs/node/pull/39586 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* doc: improve node.js+fips instructionsBenjamin Mayr2021-07-221-30/+79
| | | | | | | | | | | Improves the documentation for building Node.js with openssl-3.0.0+quic with enabled FIPS support. Adds missing but necesary steps to the documentation and makes it complete. Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/39390 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
* doc: standardize on _pull request_Rich Trott2021-07-161-1/+1
| | | | | | | | | | | | | | | | | | | | Sometimes we capitalize _pull request_ and sometimes we don't. Standardize on lowercase based on Microsoft Style Guide, Chicago Manual of Style, and GitHub's own docs and UI. Refs: https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests Refs: https://docs.github.com/en/github/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/merging-a-pull-request Refs: https://docs.microsoft.com/en-us/style-guide/capitalization PR-URL: https://github.com/nodejs/node/pull/39384 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
* doc: clarify that only one Python version is required to buildbl-ue2021-06-111-2/+2
| | | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/38894 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
* build,src,test,doc: enable FIPS for OpenSSL 3.0Daniel Bevenius2021-05-141-1/+129
| | | | | | | | | | | | | | | | | | This commit enables FIPS when Node.js is dynamically linking against quictls/openssl-3.0. BUILDING.md has been updated with instructions to configure and build quictls/openssl 3.0.0-alpha-15 and includes a couple of work-arounds which I believe are fixed in alpha-16 and can be removed when alpha-16 is available. The information might be a little too detailed/verbose but I thought it would be helpful to at least initially include all the steps. PR-URL: https://github.com/nodejs/node/pull/38633 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
* build: remove dependency on `distutils.spawn`Richard Lau2021-05-101-7/+0
| | | | | | | | | | | | | | | | | | | | | | Debian based packages of Python 3 do not include `distutils.spawn` and require an additional apt package to be installed (`python3-distutils`). Replace use of `distutils.spawn` with `shutil.which`, available in all versions of Python currently allowed by our configure scripts. For the `configure` script only, fall back to `distutils.spawn` to allow friendlier error messages when run on older unsupported versions of Python (e.g. 2.7). `configure.py` also uses `distutils.version` -- this appears to be available in Debian packaged Python 3 without installing `python3-distutils` so has been left as-is. PR-URL: https://github.com/nodejs/node/pull/38600 Refs: https://github.com/nodejs/node/issues/30189 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* doc: use `HEAD` instead of `master` for linksAntoine du Hamel2021-05-051-2/+2
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/38518 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* doc: corrected workload name as per the latest VS InstallerMrJithil2021-05-041-1/+1
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/38500 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* doc: restore minimum Xcode version for macOSRichard Lau2021-04-181-1/+1
| | | | | | | | | | | | | | https://github.com/nodejs/node/pull/36691 accidentally reverted the change to the minimum version of Xcode for macOS. PR-URL: https://github.com/nodejs/node/pull/38266 Refs: https://github.com/nodejs/node/commit/4268fae04acc16b34fb302d63b01a85725ef2043#r49622017 Refs: https://github.com/nodejs/node/pull/37872 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
View Lorry Controller Status