summaryrefslogtreecommitdiff
path: root/deps/npm/test/lib/commands/dist-tag.js
blob: b83c30e9c64ea7b609cf71f184c3c9e429c68e12 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
const t = require('tap')
const { fake: mockNpm } = require('../../fixtures/mock-npm')

let result = ''
let log = ''

t.afterEach(() => {
  result = ''
  log = ''
})

const routeMap = {
  '/-/package/@scoped%2fpkg/dist-tags': {
    latest: '1.0.0',
    a: '0.0.1',
    b: '0.5.0',
  },
  '/-/package/@scoped%2fanother/dist-tags': {
    latest: '2.0.0',
    a: '0.0.2',
    b: '0.6.0',
  },
  '/-/package/@scoped%2fanother/dist-tags/c': {
    latest: '7.7.7',
    a: '0.0.2',
    b: '0.6.0',
    c: '7.7.7',
  },
  '/-/package/workspace-a/dist-tags': {
    latest: '1.0.0',
    'latest-a': '1.0.0',
  },
  '/-/package/workspace-b/dist-tags': {
    latest: '2.0.0',
    'latest-b': '2.0.0',
  },
  '/-/package/workspace-c/dist-tags': {
    latest: '3.0.0',
    'latest-c': '3.0.0',
  },
}

// XXX overriding this does not appear to do anything, adding t.plan to things
// that use it fails the test
let npmRegistryFetchMock = (url, opts) => {
  npmRegistryFetchLog = opts.log
  if (url === '/-/package/foo/dist-tags') {
    throw new Error('no package found')
  }

  return routeMap[url]
}

let npmRegistryFetchLog
npmRegistryFetchMock.json = async (url, opts) => {
  npmRegistryFetchLog = opts.log
  return routeMap[url]
}

const logger = (...msgs) => {
  for (const msg of [...msgs]) {
    log += msg + ' '
  }

  log += '\n'
}

const DistTag = t.mock('../../../lib/commands/dist-tag.js', {
  'proc-log': {
    error: logger,
    info: logger,
    verbose: logger,
    warn: logger,
  },
  get 'npm-registry-fetch' () {
    return npmRegistryFetchMock
  },
})

const config = {}
const npm = mockNpm({
  config,
  output: msg => {
    result = result ? [result, msg].join('\n') : msg
  },
})
const distTag = new DistTag(npm)

t.afterEach(() => {
  npmRegistryFetchLog = null
})

t.test('ls in current package', async t => {
  npm.prefix = t.testdir({
    'package.json': JSON.stringify({
      name: '@scoped/pkg',
    }),
  })
  await distTag.exec(['ls'])
  t.ok(npmRegistryFetchLog, 'is passed a logger')
  t.matchSnapshot(
    result,
    'should list available tags for current package'
  )
})

t.test('ls global', async t => {
  t.teardown(() => {
    config.global = false
  })
  config.global = true
  await t.rejects(
    distTag.exec(['ls']),
    distTag.usage,
    'should throw basic usage'
  )
})

t.test('no args in current package', async t => {
  npm.prefix = t.testdir({
    'package.json': JSON.stringify({
      name: '@scoped/pkg',
    }),
  })
  await distTag.exec([])
  t.matchSnapshot(
    result,
    'should default to listing available tags for current package'
  )
})

t.test('borked cmd usage', async t => {
  npm.prefix = t.testdir({})
  await t.rejects(
    distTag.exec(['borked', '@scoped/pkg']),
    distTag.usage,
    'should show usage error'
  )
})

t.test('ls on named package', async t => {
  npm.prefix = t.testdir({})
  await distTag.exec(['ls', '@scoped/another'])
  t.matchSnapshot(
    result,
    'should list tags for the specified package'
  )
})

t.test('ls on missing package', async t => {
  npm.prefix = t.testdir({})
  await t.rejects(
    distTag.exec(['ls', 'foo']),
    distTag.usage
  )
  t.matchSnapshot(
    log,
    'should log no dist-tag found msg'
  )
})

t.test('ls on missing name in current package', async t => {
  npm.prefix = t.testdir({
    'package.json': JSON.stringify({
      version: '1.0.0',
    }),
  })
  await t.rejects(
    distTag.exec(['ls']),
    distTag.usage,
    'should throw usage error message'
  )
})

t.test('only named package arg', async t => {
  npm.prefix = t.testdir({})
  await distTag.exec(['@scoped/another'])
  t.matchSnapshot(
    result,
    'should default to listing tags for the specified package'
  )
})

t.test('workspaces', t => {
  npm.localPrefix = t.testdir({
    'package.json': JSON.stringify({
      name: 'root',
      version: '1.0.0',
      workspaces: ['workspace-a', 'workspace-b', 'workspace-c'],
    }),
    'workspace-a': {
      'package.json': JSON.stringify({
        name: 'workspace-a',
        version: '1.0.0',
      }),
    },
    'workspace-b': {
      'package.json': JSON.stringify({
        name: 'workspace-b',
        version: '1.0.0',
      }),
    },
    'workspace-c': {
      'package.json': JSON.stringify({
        name: 'workspace-c',
        version: '1.0.0',
      }),
    },
  })

  t.test('no args', async t => {
    await distTag.execWorkspaces([], [])
    t.matchSnapshot(result, 'printed the expected output')
  })

  t.test('no args, one workspace', async t => {
    await distTag.execWorkspaces([], ['workspace-a'])
    t.matchSnapshot(result, 'printed the expected output')
  })

  t.test('one arg -- .', async t => {
    await distTag.execWorkspaces(['.'], [])
    t.matchSnapshot(result, 'printed the expected output')
  })

  t.test('one arg -- .@1, ignores version spec', async t => {
    await distTag.execWorkspaces(['.@'], [])
    t.matchSnapshot(result, 'printed the expected output')
  })

  t.test('one arg -- list', async t => {
    await distTag.execWorkspaces(['list'], [])
    t.matchSnapshot(result, 'printed the expected output')
  })

  t.test('two args -- list, .', async t => {
    await distTag.execWorkspaces(['list', '.'], [])
    t.matchSnapshot(result, 'printed the expected output')
  })

  t.test('two args -- list, .@1, ignores version spec', async t => {
    await distTag.execWorkspaces(['list', '.@'], [])
    t.matchSnapshot(result, 'printed the expected output')
  })

  t.test('two args -- list, @scoped/pkg, logs a warning and ignores workspaces', async t => {
    await distTag.execWorkspaces(['list', '@scoped/pkg'], [])
    t.match(log, 'Ignoring workspaces for specified package', 'logs a warning')
    t.matchSnapshot(result, 'printed the expected output')
  })

  t.test('no args, one failing workspace sets exitCode to 1', async t => {
    npm.localPrefix = t.testdir({
      'package.json': JSON.stringify({
        name: 'root',
        version: '1.0.0',
        workspaces: ['workspace-a', 'workspace-b', 'workspace-c', 'workspace-d'],
      }),
      'workspace-a': {
        'package.json': JSON.stringify({
          name: 'workspace-a',
          version: '1.0.0',
        }),
      },
      'workspace-b': {
        'package.json': JSON.stringify({
          name: 'workspace-b',
          version: '1.0.0',
        }),
      },
      'workspace-c': {
        'package.json': JSON.stringify({
          name: 'workspace-c',
          version: '1.0.0',
        }),
      },
      'workspace-d': {
        'package.json': JSON.stringify({
          name: 'workspace-d',
          version: '1.0.0',
        }),
      },
    })

    await distTag.execWorkspaces([], [])
    t.equal(process.exitCode, 1, 'set the error status')
    process.exitCode = 0
    t.match(log, 'dist-tag ls Couldn\'t get dist-tag data for workspace-d@latest', 'logs the error')
    t.matchSnapshot(result, 'printed the expected output')
  })

  t.end()
})

t.test('add new tag', async t => {
  const _nrf = npmRegistryFetchMock
  t.teardown(() => {
    npmRegistryFetchMock = _nrf
  })

  npmRegistryFetchMock = async (url, opts) => {
    t.ok(opts.log, 'is passed a logger')
    t.equal(opts.method, 'PUT', 'should trigger request to add new tag')
    t.equal(opts.body, '7.7.7', 'should point to expected version')
  }
  npm.prefix = t.testdir({})
  await distTag.exec(['add', '@scoped/another@7.7.7', 'c'])
  t.matchSnapshot(
    result,
    'should return success msg'
  )
})

t.test('add using valid semver range as name', async t => {
  npm.prefix = t.testdir({})
  await t.rejects(
    distTag.exec(['add', '@scoped/another@7.7.7', '1.0.0']),
    /Tag name must not be a valid SemVer range: 1.0.0/,
    'should exit with semver range error'
  )
  t.matchSnapshot(
    log,
    'should return success msg'
  )
})

t.test('add missing args', async t => {
  npm.prefix = t.testdir({})
  config.tag = ''
  t.teardown(() => {
    delete config.tag
  })
  await t.rejects(
    distTag.exec(['add', '@scoped/another@7.7.7']),
    distTag.usage,
    'should exit usage error message'
  )
})

t.test('add missing pkg name', async t => {
  npm.prefix = t.testdir({})
  await t.rejects(
    distTag.exec(['add', null]),
    distTag.usage,
    'should exit usage error message'
  )
})

t.test('set existing version', async t => {
  npm.prefix = t.testdir({})
  await distTag.exec(['set', '@scoped/another@0.6.0', 'b'])
  t.matchSnapshot(
    log,
    'should log warn msg'
  )
})

t.test('remove existing tag', async t => {
  const _nrf = npmRegistryFetchMock
  t.teardown(() => {
    npmRegistryFetchMock = _nrf
  })

  npmRegistryFetchMock = async (url, opts) => {
    t.equal(opts.method, 'DELETE', 'should trigger request to remove tag')
  }
  npm.prefix = t.testdir({})
  await distTag.exec(['rm', '@scoped/another', 'c'])
  t.ok(npmRegistryFetchLog, 'is passed a logger')
  t.matchSnapshot(log, 'should log remove info')
  t.matchSnapshot(result, 'should return success msg')
})

t.test('remove non-existing tag', async t => {
  npm.prefix = t.testdir({})
  await t.rejects(
    distTag.exec(['rm', '@scoped/another', 'nonexistent']),
    /nonexistent is not a dist-tag on @scoped\/another/,
    'should exit with error'
  )
  t.matchSnapshot(log, 'should log error msg')
})

t.test('remove missing pkg name', async t => {
  npm.prefix = t.testdir({})
  await t.rejects(
    distTag.exec(['rm', null]),
    distTag.usage,
    'should exit usage error message'
  )
})

t.test('completion', async t => {
  const { completion } = distTag
  t.plan(2)

  const match = completion({ conf: { argv: { remain: ['npm', 'dist-tag'] } } })
  t.resolveMatch(match, ['add', 'rm', 'ls'],
    'should list npm dist-tag commands for completion')

  const noMatch = completion({ conf: { argv: { remain: ['npm', 'dist-tag', 'foobar'] } } })
  t.resolveMatch(noMatch, [])
  t.end()
})