diff options
| author | Stephen Finucane <sfinucan@redhat.com> | 2016-08-31 10:52:41 +0100 |
|---|---|---|
| committer | Stephen Finucane <sfinucan@redhat.com> | 2016-09-23 15:40:35 +0100 |
| commit | ebc0219a50979ba11ef7a8015270fc215191f7af (patch) | |
| tree | e61365dd1b4af3aec1cca921543c7c131e6daabb /HACKING.rst | |
| parent | 2be8f702ebf3431cc141cab3614b0136e9ccf99b (diff) | |
| download | nova-ebc0219a50979ba11ef7a8015270fc215191f7af.tar.gz | |
hacking: Always use 'assertIs(Not)None'
This is per the OpenStack style guidelines.
Change-Id: Ia706045fe3524b6b5e1db0140672776d481a0c01
Diffstat (limited to 'HACKING.rst')
| -rw-r--r-- | HACKING.rst | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/HACKING.rst b/HACKING.rst index 4ef3f28752..ad0eb0338b 100644 --- a/HACKING.rst +++ b/HACKING.rst @@ -26,8 +26,8 @@ Nova Specific Commandments assertIsInstance(A, B). - [N317] Change assertEqual(type(A), B) by optimal assert like assertIsInstance(A, B) -- [N318] Change assertEqual(A, None) or assertEqual(None, A) by optimal assert like - assertIsNone(A) +- [N318] Change assertEqual(A, None) or assertIs(A, None) to optimal assert + like assertIsNone(A) - [N319] Validate that debug level logs are not translated. - [N320] Setting CONF.* attributes directly in tests is forbidden. Use self.flags(option=value) instead. |