diff options
| author | Anh Tran <anhtt@vn.fujitsu.com> | 2016-09-27 09:11:44 +0700 |
|---|---|---|
| committer | Anh Tran <anhtt@vn.fujitsu.com> | 2016-09-27 09:14:00 +0700 |
| commit | 6ed98bd6d67e730fc7dc652dcb020b2883e49916 (patch) | |
| tree | 9246e43866f8423795c2b3653ff36b05c22fabe4 | |
| parent | 1c53f7d09837dc670e00886e201152e05084ed14 (diff) | |
| download | python-ceilometerclient-6ed98bd6d67e730fc7dc652dcb020b2883e49916.tar.gz | |
Using assertIsNone() instead of assertEqual(None)
Following OpenStack Style Guidelines[1]:
[H203] Unit test assertions tend to give better messages for more
specific assertions. As a result, assertIsNone(...) is preferred
over assertEqual(None, ...) and assertIs(..,None)
[1] http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises
Change-Id: Iae83c4360336cf07b6045615ff38933f52844499
| -rw-r--r-- | ceilometerclient/tests/unit/v2/test_alarms.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ceilometerclient/tests/unit/v2/test_alarms.py b/ceilometerclient/tests/unit/v2/test_alarms.py index 44fa50c..0557318 100644 --- a/ceilometerclient/tests/unit/v2/test_alarms.py +++ b/ceilometerclient/tests/unit/v2/test_alarms.py @@ -400,7 +400,7 @@ class AlarmManagerTest(testtools.TestCase): alarm = self.mgr.update(alarm_id='unk-alarm-id', **UPDATE_ALARM) except exc.CommandError: pass - self.assertEqual(alarm, None) + self.assertIsNone(alarm) def test_delete_from_alarm_class(self): alarm = self.mgr.get(alarm_id='alarm-id') |