| Commit message (Collapse) | Author | Age | Files | Lines |
| |\ |
|
| | |
| |
| |
| |
| |
| |
| | |
We support Python 3.6 as a minimum now, making these checks no-ops.
These file is unused in current project and remove them.
Change-Id: Ie5cbd9653375deeb523190d9c499f0c89c035d2e
|
| |/
|
|
|
|
|
| |
remove the the colorizer.py which hasn't been used
since https://review.opendev.org/c/openstack/python-cinderclient/+/502120
Change-Id: I9bed2ec947705cd53daa04678093a80581dc3282
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the import order extension to match what we have in the cinder
repo. This is a linting extension that will check that imports are in
the correct order and the correct grouping so they automatically get
flagged, and it won't be whether reviewers notice and decide to do
anything or not.
Cinder change was Ic13ba238a4a45c6219f4de131cfe0366219d722f for a little
more wordy reasoning.
Also includes updates for noqa tags. Newer version of the linters appear
to want these on the function definition line, not on the decorator
line.
Change-Id: Ibf3f3afbf3bb6ec6613b35f91d4a353c6a391f41
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
|
| |\ |
|
| | |
| |
| |
| |
| |
| | |
Replace six with Python 3 style code.
Change-Id: I4b97e040f3e790ac114dcd43c68e6b67b1079adf
|
| |/
|
|
|
|
|
|
|
|
|
|
|
| |
The current version does not work anymore with the current
testing stack.
Due to the bump, the wrapper needed a few changes
(maybe it could be dropped at some point?
Version 2.3.0 (used by cinder right now) was considered too,
but it requires a specific version of isort:
https://github.com/PyCQA/isort/issues/1273
Change-Id: I07fa32e7f49bde041d101a2d09860d0bc27acda0
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The __future__ module [1] was used in this context to ensure compatibility
between python 2 and python 3.
We previously dropped the support of python 2.7 [2] and now we only support
python 3 so we don't need to continue to use this module and the imports
listed below.
Imports commonly used and their related PEPs:
- `division` is related to PEP 238 [3]
- `print_function` is related to PEP 3105 [4]
- `unicode_literals` is related to PEP 3112 [5]
- `with_statement` is related to PEP 343 [6]
- `absolute_import` is related to PEP 328 [7]
[1] https://docs.python.org/3/library/__future__.html
[2] https://governance.openstack.org/tc/goals/selected/ussuri/drop-py27.html
[3] https://www.python.org/dev/peps/pep-0238
[4] https://www.python.org/dev/peps/pep-3105
[5] https://www.python.org/dev/peps/pep-3112
[6] https://www.python.org/dev/peps/pep-0343
[7] https://www.python.org/dev/peps/pep-0328
Change-Id: Id785793c36b3a6819a7522525252c3fef15ebe2b
|
| |
|
|
|
|
|
|
|
| |
We've kept hacking capped for a long time now. This raises the hacking
package version to the latest release and fixes the issues that it
found.
Change-Id: I69e41a340c815090f25677607e971a8e75791f6d
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On my environment, the cinderclient CLI reports:
/usr/lib/python2.7/site-packages/requests/__init__.py:91:
RequestsDependencyWarning: urllib3 (1.25.6) or
chardet (2.2.1) doesn't match a supported version!
When running any command.
This is fairly irritating to have pop up in the
context of cinder bash-completion calls, i.e.,
when you hit tab after "cinder" at the shell.
Just hide errors there rather than pollute the
screen with them.
Change-Id: I40019dcc845015de8cfe8165656829cdaa446666
|
| |
|
|
|
|
|
|
|
|
| |
In change 4cf62cf3 we started writing the
cache to ~/.cache/cinderclient/ - this script
needs to read from there.
Related-Bug: #1712835
Change-Id: Ib4de058af6b636d06ac360fe448b432e8e7733ad
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The pylint job was switched over to run under python 3, but
the job is not voting and it was apparently missed that the
conversion was causing it to fail.
This updates the version of pylint to one that is actually
supported by python 3 and makes tweaks to our script to
for the minor changes between versions.
Single character change to get rid of the more strict py3
regex string escape character format.
Change-Id: I93124b62c5ee177815457b32f55f5453fc3d387e
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
|
| |
|
|
|
|
|
|
|
|
|
| |
We do not need tox_install.sh, pip can handle constraints itself
and install the project correctly. Thus update tox.ini and remove
the now obsolete tools/tox_install.sh file.
This follows https://review.openstack.org/#/c/508061 to remove
tools/tox_install.sh.
Change-Id: I1facc619154613670444247ade567882ec84ed85
|
| |
|
|
|
|
|
| |
Adhering to coding conventions. Refer to ``Code conventions`` at
https://docs.openstack.org/contributor-guide/ for details.
Change-Id: I65e0eea36f3cb3d8d33a059e1538bf0579ca7cdd
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce new command 'list-filters' to retrieve
enabled resource filters.
```
command: cinder list-filters --resource=volume
output:
+----------------+-------------------------------+
| Resource | Filters |
+----------------+-------------------------------+
| volume | name, status, image_metadata |
+----------------+-------------------------------+
```
Also Added new option '--filters' to these list commands:
1. list
2. snapshot-list
3. backup-list
4. attachment-list
5. message-list
6. group-list
7. group-snapshot-list
8. get-pools
Change-Id: I062e6227342ea0d940a8333e84014969c33b49df
Partial: blueprint generalized-filtering-for-cinder-list-resource
Depends-On: 04bd22c1eb371805a3ce9f6c8915325bc0da2d36
Depends-On: 7fdc4688fea373afb85d929e649d311568d1855a
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Adding constraints support to clients is slightly more complex than
services as the clients themselves are listed in upper-constraints.txt
which leads to errors that you can't install a specific version and a
constrained version.
This change adds constraints support by also adding a helper script to
edit the constraints to remove python-cinderclient.
Change-Id: Iac0c8a6bcfa9a74a2e836d156642b1e0abf5ec31
|
| |
|
|
|
|
| |
TrivialFix
Change-Id: I7cc4dc71459c9cfb2f45d9b3cb551fc3d6549ddb
|
| |
|
|
|
|
|
|
|
| |
Following OpenStack Style Guidelines:
http://docs.openstack.org/developer/hacking/#dictionaries-lists
It is not clear as using explicit dictionaries
and help avoid some errors during refactoring.
Change-Id: If29fa568b757e8e08ec2bd8986d08e422db9eee4
|
| |
|
|
|
|
|
| |
ConfigParser is available in python2 but not in python3.
ref:http://www.diveintopython3.net/porting-code-to-python-3-with-2to3.html
Change-Id: Icf47e18c31a6fabf3584aead054ebd4c669a2574
|
| |
|
|
|
|
|
|
|
| |
Run pylint with
$ tox -e pylint
(Copied from Cinder with minor changes.)
Change-Id: I9d7f03c44c6da7515b433d6c87f3a1645184d491
|
| |
|
|
|
|
|
|
|
|
| |
1. Wrong use of 'noqa'. "# flake8: noqa" option disables all checks
for the whole file.
2. Remove exclusion of 'tools' and '*openstack/common*' in flake8 and
fix the violations.
Change-Id: I153e992ffd6a80e70a99d7066c503c34326c93ab
Closes-bug: #1540254
|
| |
|
|
|
|
|
|
|
| |
Options and subcommands are filtered. Now Only subcommands are shown
when subcommands is "help". Both subcommands and options are shown
when subcommand is other than "help"
Change-Id: Iad9def1b2909af33fd23b0c89559b8de30fa6547
Closes-Bug: #1399747
|
| |\ |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
With CINDER_RAX_AUTH being rightfully removed, cinderclient is no longer
compatible with Rackspace/any non-keystone auth. To fix this, I stole
auth_system/auth_plugin from novaclient's implementation.
See https://review.openstack.org/#/c/23820/.
Change-Id: If5f84003f868ef02bb7eb7da67cf62018602e8f0
Closes-Bug: 1280393
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Making this change for python-cinderclient to be consistent
with Cinder. The same change was made to Cinder via
commit ff3f2e5735f0d486b72b6881b05ace94d6d34d03 .
Partial-bug 1229324
Change-Id: I69fb960f499f0c9a9c9671d46d10170477cf6695
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Oslo commit b5cca99e5281d9c0c5eda444137e418b31209c45 removed
the obsolete redhat-eventlet.patch. Part of this commit
removed the post_process() method which we were still calling
in tools/install_venv.py . The post_process function was just
there to do any distro-specific post processing. By default,
that was nothing. So, this is safe to remove.
This same change was made to python-novaclient with
commit 0194492059920fd8d9d91849c341b2de0b561089 .
Closes-bug: 1275025
Change-Id: I4c52e2c0d3d6553f5d33e94cd6e8622160febc37
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
be81d6b Cleanup unused log related code
e53fe85 strutils bool_from_string, allow specified default
12bcdb7 Remove vim header
12d3bbc Add method quote_plus in module py3kcompat.urlutils
afdbc0a Fix E501 in individual openstack projects
Oslo Version:
8dee4b6 Merge "remove extra newlines that eventlet seems to add"
Thu, 23 Jan 2014 14:26:42 +0530 (08:56 +0000)
Change-Id: I7348e797a4a78ec20dff77ebdbb41bb8c6068b34
|
| |
|
|
|
|
|
|
|
|
|
| |
Python3 changed the behavior of dict.keys such that it is now
returns a dict_keys object, which is iterable but not indexable.
You can get the python2 result back with an explicit call to list.
Refactor list(*.keys()) so that it just uses list().
Change-Id: Ib2e9646ac967e9bd7cc4f47e2099f5d1358808a9
Signed-off-by: Chuck Short <chuck.short@canonical.com>
|
| |
|
|
|
|
|
|
|
|
| |
Wanted to get updates before next push to pypi.
The main thing driving this is we're now calling in
some methods from strutils and gettextutils that don't
have the py33 updates.
Change-Id: I358f08f5c5c0a9ee6729947a8f01b1e96de0a729
|
| |
|
|
|
|
|
|
| |
Sync strutils from oslo. Also import apiclient,
gettextutils, and importutils.
Change-Id: I565fd2cf40f2ea21842c6dbd581430b25d99fea6
Signed-off-by: Chuck Short <chuck.short@canonical.com>
|
| |
|
|
| |
Change-Id: I1649a8e777baf288b3aa4c2c29e2fe532dfe93be
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The testsuite is full of the following:
TypeError: 'dict_keys' object does not support indexing
This is due to the fact in python3 dict methods dict.keys(),
dict.items() and dict.values() return “views” instead of lists.
Change-Id: Ifa5383e6485fdbabf363fd1442877b2452346c1c
Signed-off-by: Chuck Short <chuck.short@canonical.com>
|
| |
|
|
|
|
|
| |
Basic python3 compatibilty.
Change-Id: I4388f5956cf397f8e33d20085aae6c6a728dbbda
Signed-off-by: Chuck Short <chuck.short@canonical.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use six to allow python2/pyton3 for iteritems and
iterkeys.
six.iteriems() replaces dictionary.iteritems() (python2)
and dictionary.iterms() (python3)
six.iterkeys() replaces dictionary.iterkeys (python2)
and dictionary.keys() (python3)
Change-Id: I26c80b78a7dedf3aa32eedf01a83ff6d1e592ba7
Signed-off-by: Chuck Short <chuck.short@canonical.com>
|
| |
|
|
|
|
|
|
|
|
| |
This patch adds output of tests and their results to run_tests.sh.
It also brings back colorizer to the output and updates the test-requirements.
Should align with cinder changes that are in progress
at: https://review.openstack.org/#/c/30291/
Change-Id: I3df6d861f4b4d4355464ceb2d507e69bcf682fbe
|
| |
|
|
|
|
| |
Fixes bug 1179008.
Change-Id: I6765bb82df1ae672790662a30ee3527450685036
|
| |
|
|
|
|
| |
Fixes bug 1179007.
Change-Id: I66b78ec4b5ba70a1bf1e375a5d1b7575a1879730
|
| |
|
|
|
|
| |
Fixes bug 1172444.
Change-Id: Ia063ec67de9e6061ce38b948c9eb60b5589c7bb4
|
| |
|
|
|
|
|
|
|
|
| |
pip-requires doesn't have any restrictions on prettytable.
We should match up with the pinned version in other projects.
In addition to avoid this problem in the future updated simplejson
to match openstack/requirements as well.
Change-Id: Iabf7ee8b0fd253447d1a65bc1b12906d26176286
|
| |
|
|
|
|
|
| |
This has been deprecated in favour of git-review for quite a while now
and was removed from Nova 10 months ago.
Change-Id: Ic4bfa1aee3a4b6a7588be3678ac033a1b13e2b18
|
| |
|
|
|
|
|
|
|
| |
Bump up version requirements for requests to standardize
on version >= 0.8 so it doesnt create conflict with other
openstack projects.
Change-Id: I1ed9b3bd6bdbbbb451298a3c397e6e7a06c0cabd
Signed-off-by: Chuck Short <chuck.short@canonical.com>
|
| |
|
|
|
|
|
|
|
|
|
| |
Granted - this takes the test suite from 3 seconds to 1 second... but there
are a bunch of other ways (correctness) that testr is better than nose.
Removed tests/v1/utils - it was not being used anywhere.
Part of blueprint grizzly-testtools.
Change-Id: I54d9a0b7dc22305ec60d779d6f19025a0b5dc785
|
| |
|
|
|
|
| |
Part of blueprint grizzly-testtools
Change-Id: I13e068ca156f12114eaa3a65bdb557e4eb2c988d
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
* Implement correct certificate verification
* Add --os-cacert
* Rework tests for requests
Pinned requests module to < 1.0 as 1.0.2 is now current in pipi
as of 17Dec2012.
Blueprint: tls-verify
Change-Id: I71066ff7297f3b70c08b7ae1c8ae8b6a1b82bbae
|
| |
|
|
|
|
|
|
| |
Apart of making pep8 version standard across all openstack
projects.
Change-Id: If5ef6be394e557b3554a80f1ad9b44d472c273b6
Signed-off-by: Chuck Short <chuck.short@canonical.com>
|
| |\ |
|
| | |
| |
| |
| |
| |
| |
| |
| | |
Adding nosehtmloutput as a test dependency allows nose to output its
results to an html file. This will be used by Jenkins to save logs on
a different server.
Change-Id: I439fc9742762e626610a7b0774ed1274cf38ceb7
|
| |/
|
|
|
|
| |
Resolve Bug1037422.
Change-Id: Ib36ff6eff6e84af25a8d799173524ced9e6d5d06
|
| |
|
|
| |
Change-Id: I4bcdb482149271253e12f43fb85a663b5c938a14
|
| |
|
|
|
|
|
| |
Align it with outher openstack projects.
Change-Id: I71a4b3303a354c0483c5da6a786ee6ae39388c77
Signed-off-by: Chuck Short <chuck.short@canonical.com>
|