diff options
| author | Ilya Maximets <i.maximets@samsung.com> | 2019-07-30 17:00:06 +0300 |
|---|---|---|
| committer | Ilya Maximets <i.maximets@samsung.com> | 2019-07-31 14:44:15 +0300 |
| commit | 0770429e38f49df374f6c337f4969504a97ab1b2 (patch) | |
| tree | b9aea51c4b78ffde9eba008c3db086c22862bb40 /lib/dpif-netlink.c | |
| parent | 22b78906e6c8f76cc1989eec648f9b6e36cf1266 (diff) | |
| download | openvswitch-0770429e38f49df374f6c337f4969504a97ab1b2.tar.gz | |
dpif-netlink: Allow offloading of flows with dl_type 0x1234.
'dpif_probe_feature()' always has DPIF_FP_PROBE flag set. Other probing
code uses dpif_execute() with DPIF_OP_EXECUTE, hence never calls
parse_flow_put().
Thus, this 'if' statement is wrong and should be removed as it only
forbids offloading of the real legitimate flows with dl_type 0x1234.
Dummy flows never reach this code.
CC: Paul Blakey <paulb@mellanox.com>
Fixes: 8b668ee3f0cc ("dpif-netlink: Use netdev flow put api to insert a flow")
Reported-by: Eli Britstein <elibr@mellanox.com>
Acked-by: Roi Dayan <roid@mellanox.com>
Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
Diffstat (limited to 'lib/dpif-netlink.c')
| -rw-r--r-- | lib/dpif-netlink.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c index 985a28426..7bc71d6d1 100644 --- a/lib/dpif-netlink.c +++ b/lib/dpif-netlink.c @@ -2005,11 +2005,6 @@ parse_flow_put(struct dpif_netlink *dpif, struct dpif_flow_put *put) return err; } - /* When we try to install a dummy flow from a probed feature. */ - if (match.flow.dl_type == htons(0x1234)) { - return EOPNOTSUPP; - } - in_port = match.flow.in_port.odp_port; dev = netdev_ports_get(in_port, dpif_class); if (!dev) { |