diff options
author | Alex Wang <alexw@nicira.com> | 2015-02-27 09:07:18 -0800 |
---|---|---|
committer | Alex Wang <alexw@nicira.com> | 2015-02-27 09:07:18 -0800 |
commit | 2a638b8d22be66bb631b2273a72cd4c8451de065 (patch) | |
tree | 4007bc15b1de16f71abe8824cc4a7b87fcb5824d /lib/hash.h | |
parent | 135fec593706a47dad4a9debdd50e6c13aa06f86 (diff) | |
download | openvswitch-2a638b8d22be66bb631b2273a72cd4c8451de065.tar.gz |
test-hash: Remove the check_word_hash() for hash_bytes128_cb.
The original test fails on big-endian system due to the hash function
performing not as well when input is uint32_t. In reality, users should
only use hash_bytes128() to hash words larger than 128 bits (e.g. struct
flow). Besides, we do check the 1-bit set case for 16 128-bit words in
following test case. Therefore, the cleanest way to fix the failure
in big-endian system seems to be just removing the check_word_hash()
test for hash_bytes128_cb.
Signed-off-by: Alex Wang <alexw@nicira.com>
Acked-by: Ben Pfaff <blp@nicira.com>
Diffstat (limited to 'lib/hash.h')
-rw-r--r-- | lib/hash.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/lib/hash.h b/lib/hash.h index 9253760b5..65c52b986 100644 --- a/lib/hash.h +++ b/lib/hash.h @@ -33,6 +33,7 @@ hash_rot(uint32_t x, int k) } uint32_t hash_bytes(const void *, size_t n_bytes, uint32_t basis); +/* The hash input must be a word larger than 128 bits. */ void hash_bytes128(const void *_, size_t n_bytes, uint32_t basis, ovs_u128 *out); |