diff options
| author | Ilya Maximets <i.maximets@samsung.com> | 2018-06-20 10:44:51 +0300 |
|---|---|---|
| committer | Ben Pfaff <blp@ovn.org> | 2018-07-05 10:10:19 -0700 |
| commit | 9b7dde9ae07dfbfddba2528751e00c4e7e66c56a (patch) | |
| tree | 3cf57931dbe1ae58cd769e67419d6d50c31fcfe2 /lib | |
| parent | bd3f1861bd70c187b5d077aebe91ec956516d999 (diff) | |
| download | openvswitch-9b7dde9ae07dfbfddba2528751e00c4e7e66c56a.tar.gz | |
rconn: Suppress 'connected' log for unreliable connections.
Recent assertion failure fix changed rconn workflow for unreliable
connections (such as connections from ovs-ofctl) from
|rconn|DBG|br-int<->unix#151: entering ACTIVE
|rconn|DBG|br-int<->unix#151: connection closed by peer
|rconn|DBG|br-int<->unix#151: entering DISCONNECTED
To
|rconn|DBG|br-int<->unix#200: entering CONNECTING
|rconn|INFO|br-int<->unix#200: connected
|rconn|DBG|br-int<->unix#200: entering ACTIVE
|rconn|DBG|br-int<->unix#200: connection closed by peer
|rconn|DBG|br-int<->unix#200: entering DISCONNECTED
Many monitoring/configuring tools (ex. ovs-neutron-agent) uses
ovs-ofctl frequently to check the statuses of installed flows.
This produces a lot of "connected" logs, that are useless in general.
Fix that by changing the log level to DBG for unreliable connections.
Suggested-by: Ben Pfaff <blp@ovn.org>
Fixes: c9a9b9b00bf5 ("rconn: Introduce new invariant to fix assertion failure in corner case.")
Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/rconn.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/rconn.c b/lib/rconn.c index a3f811fed..3fabc504f 100644 --- a/lib/rconn.c +++ b/lib/rconn.c @@ -511,7 +511,7 @@ run_CONNECTING(struct rconn *rc) { int retval = vconn_connect(rc->vconn); if (!retval) { - VLOG_INFO("%s: connected", rc->name); + VLOG(rc->reliable ? VLL_INFO : VLL_DBG, "%s: connected", rc->name); rc->n_successful_connections++; state_transition(rc, S_ACTIVE); rc->version = vconn_get_version(rc->vconn); |