summaryrefslogtreecommitdiff
path: root/alias.c
diff options
context:
space:
mode:
authorAlexander Couzens <lynxis@fe80.eu>2018-06-29 04:30:13 +0200
committerAlexander Couzens <lynxis@fe80.eu>2018-07-11 22:03:38 +0200
commit60293a7a3656aab8c10f2d1827d1da88ad46d32c (patch)
tree21e820844c861085dab08403e5da04f94ce43aa9 /alias.c
parent5cf79759a24e9bb2a6a3aef7c83d73efb9bf2df3 (diff)
downloadnetifd-60293a7a3656aab8c10f2d1827d1da88ad46d32c.tar.gz
replace fall throughs in switch/cases where possible with simple code changes
fall throughs are usually error-prone, especially when someone else extend it. Signed-off-by: Alexander Couzens <lynxis@fe80.eu> Acked-by: Hans Dedecker <dedeckeh@gmail.com>
Diffstat (limited to 'alias.c')
-rw-r--r--alias.c11
1 files changed, 6 insertions, 5 deletions
diff --git a/alias.c b/alias.c
index 649f2d1..3b14b87 100644
--- a/alias.c
+++ b/alias.c
@@ -87,19 +87,20 @@ alias_device_set_state(struct device *dev, bool state)
static void alias_device_cb(struct device_user *dep, enum device_event ev)
{
struct alias_device *alias;
- bool new_state = false;
alias = container_of(dep, struct alias_device, dep);
switch (ev) {
case DEV_EVENT_ADD:
- new_state = true;
+ device_set_present(&alias->dev, true);
+ break;
case DEV_EVENT_REMOVE:
- device_set_present(&alias->dev, new_state);
+ device_set_present(&alias->dev, false);
break;
case DEV_EVENT_LINK_UP:
- new_state = true;
+ device_set_link(&alias->dev, true);
+ break;
case DEV_EVENT_LINK_DOWN:
- device_set_link(&alias->dev, new_state);
+ device_set_link(&alias->dev, false);
break;
case DEV_EVENT_UPDATE_IFINDEX:
device_set_ifindex(&alias->dev, dep->dev->ifindex);