summaryrefslogtreecommitdiff
path: root/ext
diff options
context:
space:
mode:
authorKarl Williamson <khw@cpan.org>2022-12-17 08:34:33 -0700
committerKarl Williamson <khw@cpan.org>2022-12-20 05:53:42 -0700
commitcb777d7125776d73756033f32e5e2040a8826cc1 (patch)
treee278c7efa631e6f0cbe914eefa6366a3ccfa1d66 /ext
parent107344d01c0fc2b6c4ff9c599fddfb6d704bfb92 (diff)
downloadperl-cb777d7125776d73756033f32e5e2040a8826cc1.tar.gz
Fix broken API: sync_locale()
This fixes GH #20565. Lack of tests allowed sync_locale() to get broken until CPAN testing showed it so. Basically, I blew it in 9f5a615be674d7663d3b4719849baa1ba3027f5b. Most egregiously, I forgot to turn back on when a sync_locale() is executed, the toggling for locales whose radix character isn't a dot. And this needs a way to tell the other code that it needs to recompute things at this time, since our records don't reflect what happened before the sync.
Diffstat (limited to 'ext')
-rw-r--r--ext/XS-APItest/t/locale.t8
1 files changed, 2 insertions, 6 deletions
diff --git a/ext/XS-APItest/t/locale.t b/ext/XS-APItest/t/locale.t
index 19efa9546b..1a14fb45cf 100644
--- a/ext/XS-APItest/t/locale.t
+++ b/ext/XS-APItest/t/locale.t
@@ -62,12 +62,8 @@ SKIP: {
"comma recognized in global comma locale for SvNV");
isnt(sync_locale, 0, "sync_locale() returns that was in the global locale");
- TODO: {
- local $TODO = "GH #20565";
-
- is(check_in_bounds(newSvNV("4.888"), 4.88, 4.89), 1,
- "dot recognized in perl-controlled comma locale for SvNV");
- }
+ is(check_in_bounds(newSvNV("4.888"), 4.88, 4.89), 1,
+ "dot recognized in perl-controlled comma locale for SvNV");
}
my %correct_C_responses = (