diff options
| author | Nikita Popov <nikita.ppv@gmail.com> | 2019-07-07 11:23:58 +0200 |
|---|---|---|
| committer | Nikita Popov <nikita.ppv@gmail.com> | 2019-07-07 11:24:26 +0200 |
| commit | 7514b5d91c01eee72837727e853183869a156a7f (patch) | |
| tree | c35f3aa09ef1f39f53c6053801b615e2fdf3703a /CONTRIBUTING.md | |
| parent | 539b577827879f600899ad078abb8e42328453de (diff) | |
| download | php-git-7514b5d91c01eee72837727e853183869a156a7f.tar.gz | |
Mention that zend_parse_parameters should not be tested
Also mention that --CREDITS-- section should not be included
anymore. We should also change qa.php.net to stop advertising
these.
[ci skip]
Diffstat (limited to 'CONTRIBUTING.md')
| -rw-r--r-- | CONTRIBUTING.md | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index f975859032..a084bdea98 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -94,6 +94,14 @@ Submitting test scripts helps us to understand what functionality has changed. It is important for the stability and maintainability of PHP that tests are comprehensive. +Failure conditions of `zend_parse_parameters`, `ZEND_PARSE_PARAMETERS()` and +similar functions should not be tested. These parameter parsing APIs are already +extensively tested, and additional tests only complicate future modifications. + +For newly created tests, a `--CREDITS--` section should no longer be included, +as test authorship is already accurately tracked by Git. If multiple authors +should be credited, the `Co-authored-by` tag in the commit message may be used. + ## Writing documentation There are two ways to contribute to the PHP manual. You can edit the manual and |