Add else-if-used rule functional test

2 files changed, 75 insertions, 0 deletions

diff --git a/pylint/test/extensions/data/elif.py b/pylint/test/extensions/data/elif.py
new file mode 100644
index 0000000..22e79c1
--- /dev/null
+++ b/pylint/test/extensions/data/elif.py
@@ -0,0 +1,26 @@
+"""Checks use of "else if" triggers a refactor message"""
+
+def my_function():
+    """docstring"""
+    myint = 2
+    if myint > 5:
+        pass
+    else:
+        if myint <= 5:
+            pass
+        else:
+            myint = 3
+            if myint > 2:
+                if myint > 3:
+                    pass
+                elif myint == 3:
+                    pass
+                elif myint < 3:
+                    pass
+                else:
+                    if myint:
+                        pass
+            else:
+                if myint:
+                    pass
+                myint = 4
diff --git a/pylint/test/extensions/test_elseif_used.py b/pylint/test/extensions/test_elseif_used.py
new file mode 100644
index 0000000..72dc9f4
--- /dev/null
+++ b/pylint/test/extensions/test_elseif_used.py
@@ -0,0 +1,49 @@
+"""Tests for the pylint checker in :mod:`pylint.extensions.check_elif
+"""
+
+import os
+import os.path as osp
+import unittest
+
+from pylint import checkers
+from pylint.lint import PyLinter
+from pylint.reporters import BaseReporter
+from pylint.utils import register_plugins
+
+
+class TestReporter(BaseReporter):
+
+    def handle_message(self, msg):
+        self.messages.append(msg)
+
+    def on_set_current_module(self, module, filepath):
+        self.messages = []
+
+
+class CheckElseIfUsedTC(unittest.TestCase):
+
+    @classmethod
+    def setUpClass(cls):
+        cls._linter = PyLinter()
+        cls._linter.set_reporter(TestReporter())
+        checkers.initialize(cls._linter)
+        plugins_path = osp.join(osp.dirname(osp.abspath(__file__)), os.pardir,
+                                os.pardir, 'extensions')
+        register_plugins(cls._linter, plugins_path)
+
+    def test_elseif_message(self):
+        elif_test = osp.join(osp.dirname(osp.abspath(__file__)), 'data',
+                             'elif.py')
+        self._linter.check([elif_test])
+        msgs = self._linter.reporter.messages
+        self.assertEqual(len(msgs), 2)
+        for msg in msgs:
+            self.assertEqual(msg.symbol, 'else-if-used')
+            self.assertEqual(msg.msg,
+                             'Consider using "elif" instead of "else if"')
+        self.assertEqual(msgs[0].line, 9)
+        self.assertEqual(msgs[1].line, 21)
+
+
+if __name__ == '__main__':
+    unittest.main()