summaryrefslogtreecommitdiff
path: root/src/plugins/bazaar/bazaarplugin.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Vcs: Use new FilePathAspect in a few placeshjk2023-05-171-1/+1
| | | | | Change-Id: Idc23616dd3b7bc21301471cb48e2893116b83f0d Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Use PagedSettings for all plugin settingshjk2023-05-151-1/+1
| | | | | | | | | Hopefully the last structural change for a while. Settings lifetime is again tied to the plugin private. Change-Id: I221e8b8baa69422306191b48a9f034ef5b1a0dc2 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Bazaar: Follow the Fossil settings setuphjk2023-05-151-8/+7
| | | | | Change-Id: If711f8a43a6579c72cad1bc98ef24c3fdd83993b Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* All: Use the shorter access to aspect values in a few placeshjk2023-05-121-1/+1
| | | | | Change-Id: Ie0ff0e4e1cf4c2750897ea733dfccb743f44fa93 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Utils: Make Layouting a top level namespacehjk2023-04-251-1/+1
| | | | | | | | | | The whole machinery is now almost only layoutbuilder.{h,cpp}, mostly independent of the rest of Utils. Idea is to finish the separation to make it stand-alone usable also outside creator. Change-Id: I958aa667d17ae26b21209f22412309c5307a579c Reviewed-by: Eike Ziller <eike.ziller@qt.io> Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Translations: Change translation context prefix from "::" to "QtC::"Alessandro Portale2023-02-101-1/+1
| | | | | | | lupdate would be confused by translation contexts starting with :: Change-Id: Ie95e73436fd3cafc80a8e89f908efadc747e644c Reviewed-by: hjk <hjk@qt.io>
* Use simpler Plugin::initialize() when feasiblehjk2023-01-201-4/+1
| | | | | Change-Id: I567965d266f20526bda9f823e31a04b354d53fb1 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* VcsBase: Proliferate use of FilePathhjk2023-01-201-1/+1
| | | | | | | ... and update user code. Change-Id: I52c08e9e07238536d31fc72f97312ac582a1e32f Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* VcsBase: Convert to Tr::trhjk2023-01-181-1/+1
| | | | | | | | | | To reduce the amount of duplicated strings for translators to handle. The problem is not very prominent in vcsbase, but that's where we are moving everywhere else. Change-Id: Icb11fad3bccfea8a1408420e729566a75adccb66 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Remove GPL-3.0+ from license identifiersKai Köhne2023-01-061-1/+1
| | | | | | | | | | | | | | | Since we also license under GPL-3.0 WITH Qt-GPL-exception-1.0, this applies only to a hypothetical newer version of GPL, that doesn't exist yet. If such a version emerges, we can still decide to relicense... While at it, replace (deprecated) GPL-3.0 with more explicit GPL-3.0-only Change was done by running find . -type f -exec perl -pi -e "s/LicenseRef-Qt-Commercial OR GPL-3.0\+ OR GPL-3.0 WITH Qt-GPL-exception-1.0/LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0/g" {} \; Change-Id: I5097e6ce8d10233993ee30d7e25120e2659eb10b Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* VcsBase & dependent: Fix const correctnessJarek Kobus2022-12-141-2/+1
| | | | | | | And some minor cleanups. Change-Id: Id0c2df6865ba84c054f0fb97c0ac42a76a128355 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* VcsBase: Don't return editor from annotate()Jarek Kobus2022-12-111-1/+1
| | | | | | | | | Take int firstLine as last arg instead. Switch the order of 3rd and 4th args as most callers provide lineNumber and don't provide revision. Change-Id: Iab60c1068a4d9829d10219af39bf3dcbf51e37bb Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Proliferate FilePath a bit furtherhjk2022-11-091-1/+1
| | | | | Change-Id: I8490917bf0bde59b1cef2509ec14c3ca985fa43d Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* VCS: Simplify submit editor accept/close flowOrgad Shaneh2022-10-251-2/+2
| | | | | | | | | * Replace message box with an error on the output pane. * Separate logic for accept and close. Change-Id: Ib9fa201a1a67ee195086f7a22bc6678a9642452a Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: André Hartmann <aha_1980@gmx.de>
* VCS: Deduplicate some submit editor closing logicOrgad Shaneh2022-10-171-23/+0
| | | | | Change-Id: I622f5703c222a48606fcca3b99e87f9398e6a815 Reviewed-by: André Hartmann <aha_1980@gmx.de>
* VCS: Remove "Prompt to submit" settingsOrgad Shaneh2022-10-171-1/+1
| | | | | | Task-number: QTCREATORBUG-22233 Change-Id: Ifbfd738281066af7913357ff9e2466a6c983452c Reviewed-by: André Hartmann <aha_1980@gmx.de>
* VCS: Fix misuses of parentDir().absolutePath()Orgad Shaneh2022-10-111-1/+1
| | | | | | | absolutePath() *is* the parent directory. Change-Id: I59f2c4ae65b265270d432f381258b95c65e53581 Reviewed-by: hjk <hjk@qt.io>
* Port from qAsConst() to std::as_const()Marc Mutz2022-10-071-1/+1
| | | | | | | | | | | | | | We've been requiring C++17 since Qt 6.0, and our qAsConst use finally starts to bother us (QTBUG-99313), so time to port away from it now. Since qAsConst has exactly the same semantics as std::as_const (down to rvalue treatment, constexpr'ness and noexcept'ness), there's really nothing more to it than a global search-and-replace. Task-number: QTBUG-99313 Change-Id: I88edd91395849574436299b8badda21bb93bea39 Reviewed-by: hjk <hjk@qt.io>
* Vcs plugins: Replace foreach with ranged for loopJarek Kobus2022-09-301-2/+3
| | | | | Change-Id: I9be29ef128f49f62a6e1f450d8c5277b467310e9 Reviewed-by: hjk <hjk@qt.io>
* Bazaar: Convert to Tr::trhjk2022-09-261-50/+43
| | | | | | Change-Id: If49e9ccf9426f049bff842b1facbd408d1d54d4e Reviewed-by: Alessandro Portale <alessandro.portale@qt.io> Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
* Bazaar: Inline uncommitdialog.uihjk2022-09-231-9/+37
| | | | | Change-Id: I92eb7a1128394f680b473fc7cb8cb9e5e4f63f67 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Bazaar: Inline revertdialog.uihjk2022-09-231-14/+47
| | | | | Change-Id: I6cff0f874076b498f07d11ede5d4e099ba179be7 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Use SPDX license identifiersLucie Gérard2022-08-261-24/+2
| | | | | | | | | Replace the current license disclaimer in files by a SPDX-License-Identifier. Task-number: QTBUG-67283 Change-Id: I708fd1f9f2b73d60f57cc3568646929117825813 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Move ShellCommand into VcsBase pluginJarek Kobus2022-08-011-9/+9
| | | | | | | | | | Rename it to VcsCommand. Move also ShellCommandPage into VcsBase plugin. Change-Id: I335ac47e3090f2be497643ebcda0eaad2987ac81 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* VcsBase: Hide VcsCommand classJarek Kobus2022-07-131-6/+5
| | | | | | | | | | | | Make it an implementation detail. Introduce VcsBaseClient::createVcsCommand() method instead for instantiating VcsCommands. Replace all occuriences of VcsBase::VcsCommand in public API with Utils::ShellCommand. Change-Id: Ie438cc3a5e867b3ee8f9e935b56b2f16ea453f8a Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Remove Core::ShellCommandJarek Kobus2022-07-111-9/+8
| | | | | | | | Move the implementation into VcsCommand. Use Utils::ShellCommand inside coreplugin API. Change-Id: I74a34057b33832a138b05f1dfa6937565027edb4 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* QtcProcess: Limit the inclusion of qtcprocess.hJarek Kobus2022-03-021-0/+2
| | | | | | | | | | Move the rest of QtcProcess enums to processenums.h. Move ExitCodeInterpreter into processenums.h. Remove superfluous Utils:: prefix. Change-Id: Iaa596f353d33d6930085a621b114cc15a35caa80 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* EditorManager: Remove QString openEditor(At) overloadsEike Ziller2021-11-021-1/+1
| | | | | | | | In favor of the FilePath/Link ones. Change-Id: I5caf9e0f8de304ff4ee12329557aa50a6f3a0c69 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: David Schulz <david.schulz@qt.io>
* Bazaar: Simplify BazaarPluginPrivate::isConfigured() checkhjk2021-08-201-4/+1
| | | | | Change-Id: If3e940c38149f5ae75d99582593918f4847c8c3e Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Use more FilePath for file pathshjk2021-08-021-22/+19
| | | | | Change-Id: I855cde65d034a9647972a7fddf1e8266d7ccfa88 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* VCS: Partially use FilePath in VcsBaseClienthjk2021-07-301-1/+1
| | | | | Change-Id: I024b051ab98ece42ec011bd1c92887a946925c1a Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Replace findRepositoryForDirectoryhjk2021-07-301-3/+2
| | | | | | | | By some function findRepositoryForFile operating on any file and using FilePath. Change-Id: I91b8aa38b1c6b33993b9b790fbc2ff4d378ad8a8 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Use FilePath in IVersionControl APIhjk2021-07-291-27/+27
| | | | | | | | Adapt first level of users. Change-Id: Ifcd7bff45631ff3b9e26a9e3176daa6cf0cf2e56 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Utils: filepathify fileutilsDavid Schulz2021-05-181-1/+1
| | | | | Change-Id: Ic9048369f64d793f5f567cdb0c715488fb5a4ff6 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Vcs/Utils: Use Utils::Environment for ShellCommandhjk2021-05-051-2/+2
| | | | | Change-Id: Ica289ab2f83d52270923c4ff4983860cfbe0b494 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Bazaar: Use the new AspectContainer::applied signalhjk2021-04-071-2/+3
| | | | | | | Also, remove unused BazaarSettings::sameUserId() Change-Id: Ie3e39f2dff506932a2b6ef0a3dbffae9e40db64c Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Locator: Add longer description to filtersEike Ziller2021-03-231-0/+1
| | | | | | | | | | This is shown as tool tips in the location options, and if any platform supports this also as tool tips on the menu actions of the locator input field. Change-Id: I8b439e45e6097a16a5f932d25d4e5d3e9bddb6ad Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: David Schulz <david.schulz@qt.io>
* Bazaar: Aspectify settingshjk2021-03-191-5/+4
| | | | | Change-Id: I0354698cf3473dd096e57481a945f0f59afc75b3 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* EditorManager: Small API clean-upEike Ziller2020-09-301-1/+1
| | | | | | | | | - Move private enum to private header - Add missing parameter to openEditorAtSearchResult - Remove convenience singular close* methods, we have {} nowadays Change-Id: Ic5b6d831a9f506ffee09b89b3358874433d62998 Reviewed-by: David Schulz <david.schulz@qt.io>
* Utils: Drop Utils::SkipEmptyParts againhjk2020-07-211-1/+1
| | | | | | | | We require Qt 5.14 nowadays. Change-Id: Iff245257d3cb19207007c0445ee13814e66152dd Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Core/Utils: Migrate further to Utils::Idhjk2020-07-061-4/+3
| | | | | | | The coreplugin/id.h header is kept for downstream for now. Change-Id: I8c44590f7b988b3770ecdc177c40783e12353e66 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* VCS: Add vcsDescribeOrgad Shaneh2020-06-181-5/+4
| | | | | | | Already exists in all implementations, but there was no common declaration. Change-Id: Ieb3d10d1936c207722b5001712bce41e8114dcdc Reviewed-by: André Hartmann <aha_1980@gmx.de>
* IVersionControl: Change vcsAnnotate return type to voidOrgad Shaneh2020-06-181-3/+2
| | | | | | | | | | | All implementations return true unconditionally, and the return value is never read anyway. + Remove superfluous function with the same name in Perforce. Change-Id: I83f361ec7fd8be3177cb4be52e6276e295cd4279 Reviewed-by: André Hartmann <aha_1980@gmx.de> Reviewed-by: hjk <hjk@qt.io>
* All: Use Utils::SkipEmptyPartshjk2020-06-171-1/+2
| | | | | | Task-number: QTCREATORBUG-24098 Change-Id: Iab45de9a9c17ddc39a0e343b1175d4f6cb94b098 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Vcs: Make VcsBaseEditorWidget::test* operate on factories directlyhjk2020-02-131-2/+2
| | | | | | | Saves re-discovery by id. Change-Id: I026c1388d02f125147a9b4f5367d7a1a266bff3c Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Make some editor factories proper plugin pimpl membershjk2020-02-071-27/+43
| | | | | Change-Id: I7f815c53bac8621b2198c57d7f1d7d4bd43eb282 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Move responsibility to set editor parameters to editor factoryhjk2020-02-061-2/+2
| | | | | | | | | | | | So it doesn't need to be named twice in the editor factory setup. This intentially includes a de-optimiztion: storing the parameters by value, not by pointer. That's more natural, does not need to keep the parameters alive on the caller side, and it's uncritical in this context. Change-Id: I92867d3f2f75c38911ae82d3eeb4759cba71b723 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* VcsBase: More use of settings instead of client when it sufficeshjk2020-02-041-1/+1
| | | | | | | | Client::vcsBinary() maps directly to Settings::binaryPath() except for git can be replaced by that in non-generic settings. Change-Id: I245659d3c423361e87c92e8995fa3476d798cc7b Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Remove some unneded indirectionshjk2020-01-311-7/+6
| | | | | Change-Id: Ie9d976c06ff424fb106cb344bedb789c9b99e657 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Merge IVersionControl and VcsBasePlugin hierarchieshjk2020-01-311-5/+155
| | | | | | | | | | | | | | They were 1:1 in parallel, with quite a bit of function call ping-pong inbetween, for code-sharing-by-inheritance. Merge them by making VcsBasePlugin inherit IVersionControl and merge the derived classes below. Size of this patch is hard to avoid as all seven systems have to move simultaneously. Non-necessary potential follow-up cleanup have been left out on purpose. Change-Id: Icb71e4182af3db21069cc637e7ae87ffa3829791 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
View Lorry Controller Status