summaryrefslogtreecommitdiff
path: root/src/plugins/git/gerrit/gerritplugin.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Git: Use LayoutBuilder in Gerrit options pagehjk2023-05-081-9/+11
| | | | | | | | Move towards using aspects and away from IOptionPage's QObject base. Change-Id: I07850a6b8e9fa7d2591efc6f76a23f249dfc164f Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Git: Small simplification to Gerrit "plugin" setuphjk2023-05-081-4/+3
| | | | | | | | The indirection is not needed. It's not really stand-alone, and not touched before GitPlugin::initialize(). Change-Id: If8552dc69ff9efa18a3f1d6d998a8f28ab65e501 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Utils: Rename qtcprocess.{cpp,h} -> process.{cpp,h}Jarek Kobus2023-05-041-1/+1
| | | | | | | | Follows QtcProcess -> Process rename. Change-Id: I97235a9a40cb7fd52944515b7ab878d96528f919 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* Utils: Rename QtcProcess -> ProcessJarek Kobus2023-05-041-4/+4
| | | | | | | | Task-number: QTCREATORBUG-29102 Change-Id: Ibc264f9db6a32206e4097766ee3f7d0b35225a5c Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: hjk <hjk@qt.io>
* VcsBase: Proliferate use of FilePathhjk2023-01-201-1/+1
| | | | | | | ... and update user code. Change-Id: I52c08e9e07238536d31fc72f97312ac582a1e32f Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Utils: Rename QtcProcess::readAllStandard* to readAllRawStandard*hjk2023-01-101-2/+2
| | | | | | | | | | | | ... and re-use the old QtcProcess::readAllStandard* names for a QString-returning 'decoded' version. For now, only use that in 'full Utf8' cases, to stay bug-compatible, the plan is, however, to employ the QTextCodecs we have already in the channel buffers. That will be one-by-one, though. Change-Id: Id209e0671920d4ea4197918e872f441254112d52 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Remove GPL-3.0+ from license identifiersKai Köhne2023-01-061-1/+1
| | | | | | | | | | | | | | | Since we also license under GPL-3.0 WITH Qt-GPL-exception-1.0, this applies only to a hypothetical newer version of GPL, that doesn't exist yet. If such a version emerges, we can still decide to relicense... While at it, replace (deprecated) GPL-3.0 with more explicit GPL-3.0-only Change was done by running find . -type f -exec perl -pi -e "s/LicenseRef-Qt-Commercial OR GPL-3.0\+ OR GPL-3.0 WITH Qt-GPL-exception-1.0/LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0/g" {} \; Change-Id: I5097e6ce8d10233993ee30d7e25120e2659eb10b Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* GerritPlugin: Reuse ProcessProgressJarek Kobus2023-01-041-99/+24
| | | | | | | | Get rid of unneeded State enum, future watcher and future interface. Change-Id: Id217d557c9051479cd3da872c1661c163cdf3a21 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Git/VCS: Use ctrlc stub for process executionOrgad Shaneh2022-12-151-0/+1
| | | | | | | | | | | | | | | | This ensures that child processes are also terminated. Required specifically for Git on Windows, when running in cmd directory, which spawns a child process for usr/bin/git. On this case, if git takes long to finish and is aborted while running, the main process was killed as expected, but the child process remained alive. Task-number: QTCREATORBUG-27567 Change-Id: I40271eb42cfaefd81f2fe5af138254ab0a2c8da8 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Christian Stenger <christian.stenger@qt.io> Reviewed-by: David Schulz <david.schulz@qt.io> Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
* VcsBase: Pass context object to lambda connectionsJarek Kobus2022-12-071-1/+1
| | | | | | | | Remove some unneeded lambda () brackets. Change-Id: I20e43625793401544e86efb627f5921c395026bb Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
* Git: Convert to Tr::trAlessandro Portale2022-10-061-11/+13
| | | | | Change-Id: I7fb1753109a9263c70c01713f5f4895db6b73662 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* VcsManager: Use more FilePathJarek Kobus2022-10-051-14/+11
| | | | | Change-Id: I255372c47e6d3ea55e5f8060c3c2fdd9bd155c75 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Use SPDX license identifiersLucie Gérard2022-08-261-24/+2
| | | | | | | | | Replace the current license disclaimer in files by a SPDX-License-Identifier. Task-number: QTBUG-67283 Change-Id: I708fd1f9f2b73d60f57cc3568646929117825813 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* FetchContext: Connect to done() signalJarek Kobus2022-06-161-34/+17
| | | | | | | | Instead of connecting to errorOccurred() and finished() signals. Change-Id: I16e0de8422be989bf56cc6c5b865966f97013731 Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
* Replace QtcProcess::stopProcess() by stop() plus waitForFinishedhjk2022-06-161-1/+2
| | | | | | | ... or nothing, if the process object is destroyed immediately. Change-Id: I6a1e1928bc49fc20a1c0e0ee9b8f4f723276bbca Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
* QtcProcess: Forward declare Environment in QtcProcess headerJarek Kobus2022-05-091-0/+1
| | | | | | Change-Id: If85a8a07b144c94cb6e45f66dcb06573ef07c777 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: hjk <hjk@qt.io>
* Register some more windowsEike Ziller2022-02-091-0/+1
| | | | | | | | So they get an entry in the Window menu, and window related shortcuts are registered correctly. Change-Id: Ie7e882a009f928f1268fdd312e7fb5362f6a837f Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Use more FileUtils based file dialogshjk2021-08-191-4/+3
| | | | | Change-Id: I1e7ec0493c26afe58e17afb8923a2b1023f6dcd4 Reviewed-by: David Schulz <david.schulz@qt.io>
* VCS: Use more FilePath in ShellCommand and surroundingshjk2021-08-171-1/+1
| | | | | | Change-Id: Ie8c5fac09b45a54bcbe9a876044b653e7fccede5 Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* Use refactored ProcessModeJarek Kobus2021-08-091-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch needs to be applied together with the parent change. There are 3 basic cases: 1. The user doesn't write anything to the write channel: You don't need to call closeWriteChannel manually anymore. By default the QtcProcess you create is in ProcessMode::Reader mode. Internally it opens the process in ReadOnly mode and closes the write channel just after starting. 2. The user writes some initial data (after being started) and then closes the write channel: All what is needed now it to set the write data (QtcProcess::setWriteData) before calling start. You also use the default ProcessMode::Reader mode. Internally it opens the process in ReadWrite mode and writes the writeData asynchonously when the process already started. After writing the data it closes the write channel automatically. 3. The user writes the data also after calling start. All you need now is to create a process with ProcessMode::Writer mode. In this mode the write channel is not closed. Internally it opens the process in ReadWrite mode as some writers also read the data from the process. All the code base is adapted here to the above rules. Change-Id: Id103019d1d71a3012fd1eade226fe96b9aaa48c2 Reviewed-by: hjk <hjk@qt.io>
* Vcs: Use more FilePath for file pathshjk2021-08-021-16/+16
| | | | | Change-Id: I855cde65d034a9647972a7fddf1e8266d7ccfa88 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Utils: Drop QProcess specific parameters from QtcProcess::finished()hjk2021-06-141-5/+5
| | | | | | | | | | | Mid-term plan is to concentrate on use of QtcProcess::result() instead which is a bit more system-agnostic. There's quite a bit of potential for downstream cleanup by re-using QtcProcess::exitMessage() now. Change-Id: I3806b3f5933d96e64b7cfb18cc6c52823fddcbcd Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: Move QProcess base to QtcProcessPrivatehjk2021-06-021-5/+4
| | | | | Change-Id: I4c6811d42e051fadfcf32edb664ff3bc09e692e6 Reviewed-by: David Schulz <david.schulz@qt.io>
* Git: Use QtcProcess instead of SychronouceProcess helper functionshjk2021-05-051-7/+9
| | | | | Change-Id: I76b21d046676b454f49970e8602f33b759f3c6c5 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs/Utils: Use Utils::Environment for ShellCommandhjk2021-05-051-1/+2
| | | | | Change-Id: Ica289ab2f83d52270923c4ff4983860cfbe0b494 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Git: Replace QRegExp by QRegularExpressionChristian Stenger2020-07-141-4/+4
| | | | | | Task-number: QTCREATORBUG-24098 Change-Id: I77a2e9959981b2e173142253baf1668d57982a2e Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Git: Store singleton instance in GitClientOrgad Shaneh2020-02-261-10/+10
| | | | | | | | On many cases, GitPlugin is not required at all, and is only used as a proxy for GitClient. Change-Id: I246012658ab3e8c7a12f1a459b1b1748ff358e0b Reviewed-by: hjk <hjk@qt.io>
* Git: Partially move plugin pimpl to .cpphjk2020-02-071-12/+12
| | | | | | | | | | Same procedure as for ClearCase. Unfortuately, some deep accesses are not easy to get rid of. Make them available by static functions in the plugin itself. Definitely not the favorite setup, but allows to proceed with the QObject removals. Change-Id: Id85ed07bc7a6c1c053431a14dd7f68892f7ebea0 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Merge IVersionControl and VcsBasePlugin hierarchieshjk2020-01-311-2/+1
| | | | | | | | | | | | | | They were 1:1 in parallel, with quite a bit of function call ping-pong inbetween, for code-sharing-by-inheritance. Merge them by making VcsBasePlugin inherit IVersionControl and merge the derived classes below. Size of this patch is hard to avoid as all seven systems have to move simultaneously. Non-necessary potential follow-up cleanup have been left out on purpose. Change-Id: Icb71e4182af3db21069cc637e7ae87ffa3829791 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Pimpl pluginshjk2020-01-241-14/+13
| | | | | | | | | | | | | | | Essentially rename all *Plugin into *PluginPrivate, and pull out the actual IPlugin related pieces into new *Plugin classes. Shift the construction of the PluginPrivate to initialize(), following the general pattern. I tried to keep the patch as mechanical as possible, giving room to some obvious but less mechanical cleanup needs, that are intentionally left out of this here. Change-Id: Iac662bf73338f9f7669064ed67b960246875c23c Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Utils: Use CommandLine in ShellCommandhjk2019-06-111-1/+1
| | | | | | | ... and adapt users. Change-Id: I218523ffe34720d5fe199aa0ca6892a8dc2985fc Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Utils: Rename FileName to FilePathhjk2019-05-281-6/+6
| | | | | | | | More in line with QFileInfo terminonlogy which appears to be best-of-breed within Qt. Change-Id: I1d051ff1c8363ebd4ee56376451df45216c4c9ab Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Replace static_casts by QOverload where possiblehjk2019-02-261-1/+1
| | | | | | | | | Mainly to get rid of the QProcess::finished deprecation warning. Also adjust coding style in the surrounding connects when needed. Change-Id: I12f9b248c7974b892c4a069356e578e80f8c59e9 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Merge remote-tracking branch 'origin/4.8'Orgad Shaneh2018-12-031-4/+4
|\ | | | | | | Change-Id: I5b18233936e3b2cd674df92a694ba73b5a3ed752
| * Git: Use ICore::dialogParent as dialog parentOrgad Shaneh2018-11-291-4/+4
| | | | | | | | | | Change-Id: Idc3f2f4d27d3279f76b688fac635e8d38b2705f5 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* | Git: ModernizeAlessandro Portale2018-11-101-3/+1
|/ | | | | | | | | modernize-use-using modernize-use-default-member-init modernize-use-equals-default Change-Id: Iaccd5611cfc2056d357a0545f8522f02d6f8f0ed Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Git: Make checkout asynchronousOrgad Shaneh2018-10-101-1/+1
| | | | | | | | It can be slow when many files are replaced. Change-Id: I308698ef36973374f4526107fbda0d9ad907e707 Reviewed-by: Eike Ziller <eike.ziller@qt.io> Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* Git: ModernizeOrgad Shaneh2018-09-191-3/+2
| | | | | | | | | * Use auto * Use override * Use some member initializers Change-Id: I3ca000d1c8e4d02331d58b85e68e4d771c636b29 Reviewed-by: André Hartmann <aha_1980@gmx.de>
* Gerrit: Update remotes on settings changeOrgad Shaneh2018-06-191-1/+6
| | | | | | | | If the user is changed, we need to refresh at least the fallback server. Task-number: QTCREATORBUG-20536 Change-Id: If21830ae5607907db9aaee164bc85b971ff93010 Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* Gerrit: Fix modality of warning message for invalid configurationOrgad Shaneh2018-06-191-2/+2
| | | | | | Task-number: QTCREATORBUG-20535 Change-Id: I4963e3856da12b40a323fbcdab6f0a12a9e15293 Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* Gerrit: Do not refresh dialog on update remotes when hiddenOrgad Shaneh2018-06-011-1/+1
| | | | | Change-Id: Ie9b00c1a117b1b2a3823dcb9249ed563b3dbd4a7 Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* Gerrit: Fix some clang-tidy warningsOrgad Shaneh2018-06-011-1/+0
| | | | | Change-Id: Idaccca0bd6d7682feeac8a0964ce2abb788f3e99 Reviewed-by: André Hartmann <aha_1980@gmx.de>
* Vcs/Text search: Remove a few addAutoReleaseObject useshjk2018-02-061-1/+1
| | | | | | | Using a QObject parent suffices here. Change-Id: I4dc5448511d55bf14fbd8f810e91336a49e94094 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Merge remote-tracking branch 'origin/4.5'Eike Ziller2018-01-091-3/+8
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: src/plugins/cpptools/clangcompileroptionsbuilder.cpp src/plugins/cpptools/clangcompileroptionsbuilder.h src/plugins/cpptools/compileroptionsbuilder.cpp src/plugins/qmlprofiler/qmlprofilerclientmanager.cpp src/plugins/qmlprofiler/qmlprofilerclientmanager.h src/plugins/qmlprofiler/qmlprofilertraceclient.cpp src/plugins/qmlprofiler/qmlprofilertraceclient.h src/shared/qbs Change-Id: I364ababc5d41046d17e999096c4a7187c4e4e010
| * Gerrit: Set current repository every time the dialog is shownOrgad Shaneh2018-01-081-0/+1
| | | | | | | | | | | | Task-number: QTCREATORBUG-19562 Change-Id: I17918e08f7d3092ffe54ab359bf2b41c51813367 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
| * Gerrit: Deduplicate detection of current repositoryOrgad Shaneh2018-01-081-3/+7
| | | | | | | | | | | | Change-Id: Ib3a63f71dd45c45b20eab51a2a0bf9c21ba8754a Reviewed-by: André Hartmann <aha_1980@gmx.de> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* | Gerrit: Move push target logic to GerritPushDialogOrgad Shaneh2017-10-151-19/+1
|/ | | | | | | Less indirection + will simplify new private/wip flags. Change-Id: If8c4072b6456b4044d83ef17e130e0360a1d05f8 Reviewed-by: André Hartmann <aha_1980@gmx.de>
* Gerrit: Improve error message when Gerrit remote is missingOrgad Shaneh2017-10-131-3/+3
| | | | | | | Task-number: QTCREATORBUG-18980 Change-Id: I99336732d59136f9aec9fc0a97fb3135e9c43f65 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* Make DocumentManager::projectsDirectory a FileNameEike Ziller2017-09-191-1/+1
| | | | | Change-Id: I9454c2148c398939c64bfa6b1fc182670a1d5f99 Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* Gerrit: Show only gerrit remotes in Push to Gerrit dialogOrgad Shaneh2017-07-011-1/+1
| | | | | | Task-number: QTCREATORBUG-16367 Change-Id: I18e24dd0748bd64790bd8d2c0eeeee2cf1d3991a Reviewed-by: André Hartmann <aha_1980@gmx.de>
View Lorry Controller Status