summaryrefslogtreecommitdiff
path: root/src/plugins/git/gerrit/gerritpushdialog.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Utils: Make Layouting a top level namespacehjk2023-04-251-1/+1
| | | | | | | | | | The whole machinery is now almost only layoutbuilder.{h,cpp}, mostly independent of the rest of Utils. Idea is to finish the separation to make it stand-alone usable also outside creator. Change-Id: I958aa667d17ae26b21209f22412309c5307a579c Reviewed-by: Eike Ziller <eike.ziller@qt.io> Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Git: Fix explanation in GerritPushDialogRobert Löhning2023-03-271-1/+1
| | | | | | | Change-Id: I527414dc3948a009099ec993c0f71d3501394ecd Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
* Proliferate Tr::tr in various placesAlessandro Portale2023-02-101-14/+16
| | | | | | | | | | This changes several tr() calls which were either missed during Tr::tr- ization or were added later. Found with regular expression: (?<!(Tr::)|([\w]))tr\( Change-Id: I1c0c03589e941614a7a8449ecfebc7d2cad396c3 Reviewed-by: hjk <hjk@qt.io>
* Remove GPL-3.0+ from license identifiersKai Köhne2023-01-061-1/+1
| | | | | | | | | | | | | | | Since we also license under GPL-3.0 WITH Qt-GPL-exception-1.0, this applies only to a hypothetical newer version of GPL, that doesn't exist yet. If such a version emerges, we can still decide to relicense... While at it, replace (deprecated) GPL-3.0 with more explicit GPL-3.0-only Change was done by running find . -type f -exec perl -pi -e "s/LicenseRef-Qt-Commercial OR GPL-3.0\+ OR GPL-3.0 WITH Qt-GPL-exception-1.0/LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0/g" {} \; Change-Id: I5097e6ce8d10233993ee30d7e25120e2659eb10b Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* VcsBase & dependent: Fix const correctnessJarek Kobus2022-12-141-9/+4
| | | | | | | And some minor cleanups. Change-Id: Id0c2df6865ba84c054f0fb97c0ac42a76a128355 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Git: GerritPushDialog: Use LayoutingJarek Kobus2022-11-181-85/+119
| | | | | Change-Id: I5b0a95680e683cf6e5b938b4a4a74bfc0c5b45e2 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Git: Convert to Tr::trAlessandro Portale2022-10-061-10/+11
| | | | | Change-Id: I7fb1753109a9263c70c01713f5f4895db6b73662 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Various plugins: Limit the usage of qMakePairJarek Kobus2022-09-301-1/+1
| | | | | Change-Id: I9113dd47fb4f9026f3a732aebbd0aee31651b727 Reviewed-by: hjk <hjk@qt.io>
* Use SPDX license identifiersLucie Gérard2022-08-261-24/+2
| | | | | | | | | Replace the current license disclaimer in files by a SPDX-License-Identifier. Task-number: QTBUG-67283 Change-Id: I708fd1f9f2b73d60f57cc3568646929117825813 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Drop Qt5: VCS: Get rid of QComboBox QOverloadJarek Kobus2022-07-191-2/+2
| | | | | Change-Id: Ib2f21f28a0ec16b817f9227c6234424001752d50 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Use more FilePath for file pathshjk2021-08-021-2/+2
| | | | | Change-Id: I855cde65d034a9647972a7fddf1e8266d7ccfa88 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* VCS: Fix build with Qt6Eike Ziller2020-09-211-1/+1
| | | | | | | | | QStringRef is gone. Task-number: QTCREATORBUG-24098 Change-Id: I38dd1602294fcabf5cf7c1553bcfd93f3c47b601 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Git: Filter out commits according to active remoteOrgad Shaneh2020-08-101-0/+9
| | | | | | | | ... in the Push to Gerrit dialog. Fixes: QTCREATORBUG-24436 Change-Id: I2f1ab49d9fbeb09ffb66de23d34a2facd53cb725 Reviewed-by: André Hartmann <aha_1980@gmx.de>
* Utils: Drop Utils::SkipEmptyParts againhjk2020-07-211-1/+1
| | | | | | | | We require Qt 5.14 nowadays. Change-Id: Iff245257d3cb19207007c0445ee13814e66152dd Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* All: Use Utils::SkipEmptyPartshjk2020-06-171-1/+2
| | | | | | Task-number: QTCREATORBUG-24098 Change-Id: Iab45de9a9c17ddc39a0e343b1175d4f6cb94b098 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Port from QRegExpValidator to QRegularExpressionValidatorLars Knoll2020-03-201-2/+2
| | | | | | | | QRegExpValidator is going away in Qt6, so port over to the version using QRegularExpression. Change-Id: Iecd1ba1f0e5e01009ae43b79c1ccc73f0fc046b2 Reviewed-by: hjk <hjk@qt.io>
* Git: Store singleton instance in GitClientOrgad Shaneh2020-02-261-10/+9
| | | | | | | | On many cases, GitPlugin is not required at all, and is only used as a proxy for GitClient. Change-Id: I246012658ab3e8c7a12f1a459b1b1748ff358e0b Reviewed-by: hjk <hjk@qt.io>
* Globally disable WindowContextHelpButtonHintKai Koehne2020-02-251-1/+0
| | | | | | | | | | | Do set the global application flag AA_DisableWindowContextHelpButton to avoid having to unset the default WindowContextHelpButtonHint in every single dialog. AA_DisableWindowContextHelpButton was added in Qt 5.10. Change-Id: I21fe8bc5ddfa4c01ec7a799b04bfb6ff1c9d6d86 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Git: Partially move plugin pimpl to .cpphjk2020-02-071-7/+7
| | | | | | | | | | Same procedure as for ClearCase. Unfortuately, some deep accesses are not easy to get rid of. Make them available by static functions in the plugin itself. Definitely not the favorite setup, but allows to proceed with the QObject removals. Change-Id: Id85ed07bc7a6c1c053431a14dd7f68892f7ebea0 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Pimpl pluginshjk2020-01-241-7/+7
| | | | | | | | | | | | | | | Essentially rename all *Plugin into *PluginPrivate, and pull out the actual IPlugin related pieces into new *Plugin classes. Shift the construction of the PluginPrivate to initialize(), following the general pattern. I tried to keep the patch as mechanical as possible, giving room to some obvious but less mechanical cleanup needs, that are intentionally left out of this here. Change-Id: Iac662bf73338f9f7669064ed67b960246875c23c Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Remove usages of deprecated APIsSona Kurazyan2019-09-031-1/+1
| | | | | | | | | | | | Replaced: QPalette::ColorRole::Background -> QPalette::ColorRole::Window QPalette::ColorRole::Foreground -> QPalette::ColorRole::WindowText Qt::ItemDataRole::TextColorRole -> Qt::ItemDataRole::ForegroundRole QFontMetrics::width() -> QFontMetrics::horizontalAdvance() Task-number: QTBUG-76491 Change-Id: I1302e6b569e725daa6f7be1428ffe055657fc644 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Replace static_casts by QOverload where possiblehjk2019-02-261-2/+2
| | | | | | | | | Mainly to get rid of the QProcess::finished deprecation warning. Also adjust coding style in the surrounding connects when needed. Change-Id: I12f9b248c7974b892c4a069356e578e80f8c59e9 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Merge remote-tracking branch 'origin/master' into 4.8Eike Ziller2018-09-211-1/+1
|\ | | | | | | Change-Id: I99d7e3aa727316db2e4909be6c0ea7583b90c816
| * Git: ModernizeOrgad Shaneh2018-09-191-1/+1
| | | | | | | | | | | | | | | | | | * Use auto * Use override * Use some member initializers Change-Id: I3ca000d1c8e4d02331d58b85e68e4d771c636b29 Reviewed-by: André Hartmann <aha_1980@gmx.de>
* | Git: Avoid usage of deprecated QDateTime::fromTime_tOrgad Shaneh2018-09-211-2/+2
|/ | | | | Change-Id: I37ce617990ee385e37261624d847a0aef757d283 Reviewed-by: André Hartmann <aha_1980@gmx.de>
* Gerrit: Fix some clang-tidy warningsOrgad Shaneh2018-06-011-1/+1
| | | | | Change-Id: Idaccca0bd6d7682feeac8a0964ce2abb788f3e99 Reviewed-by: André Hartmann <aha_1980@gmx.de>
* Gerrit: Warn when probably pushing to wrong branchOrgad Shaneh2018-05-021-2/+16
| | | | | | | | | For rebase/merge strategies, this can cause real problems (when the target branch is forwarded to a more recent branch...) Task-number: QTCREATORBUG-20062 Change-Id: Ic7c282a1e0571b31d9333290141817c59daa0e7a Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* Gerrit: Fix UI textLeena Miettinen2018-02-051-9/+9
| | | | | Change-Id: I5be1fc3629961dbc224d65d1bc52efc9a4613d2a Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Git: Gerritpushdialog: Fix draft push for older GerritsAlessandro Portale2017-12-031-1/+1
| | | | | | | Logic for "Non-Draft" and "Draft" was swapped. Change-Id: I14640e1a6321332c6f0cc0b3e8364194f52bcbaf Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Gerrit: Support Private/Work-In-Progress push on Gerrit >= 2.15Orgad Shaneh2017-10-171-6/+58
| | | | | | | | | | | | | | A private change[1] is only visible to the uploader and reviewers (like draft in older Gerrit). A WIP change[2] does not generate notifications until it becomes ready. [1] https://gerrit-review.googlesource.com/Documentation/intro-user.html#private-changes [2] https://gerrit-review.googlesource.com/Documentation/user-upload.html#wip Change-Id: I4905461c529e93e86be934c60eab218ff7474fcd Reviewed-by: André Hartmann <aha_1980@gmx.de> Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* Gerrit: Move push target logic to GerritPushDialogOrgad Shaneh2017-10-151-5/+21
| | | | | | | Less indirection + will simplify new private/wip flags. Change-Id: If8c4072b6456b4044d83ef17e130e0360a1d05f8 Reviewed-by: André Hartmann <aha_1980@gmx.de>
* Merge remote-tracking branch 'origin/4.5'Orgad Shaneh2017-10-151-5/+5
|\ | | | | | | Change-Id: I2d78020f10aa66fdded63883030313e0c411ce02
| * Gerrit: Improve error message when Gerrit remote is missingOrgad Shaneh2017-10-131-5/+5
| | | | | | | | | | | | | | Task-number: QTCREATORBUG-18980 Change-Id: I99336732d59136f9aec9fc0a97fb3135e9c43f65 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* | Replace manual signal blocking/unblocking with QSignalBlockerTobias Hunger2017-10-041-33/+34
|/ | | | | | Change-Id: Ibb59fab4e37d045e506c5a8172b6f5cbb955b028 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* PushToGerrit: Fix support for multiple projects on the same remoteOrgad Shaneh2017-09-111-1/+1
| | | | | | | | | Use case: A project has a legacy repo and a new repo. Both are used as remotes in the same local directory. If the legacy repo's remote name is less than the current repo (legacy < origin) then only legacy appears. Change-Id: Ie02cbee3142c4d2628cb51cbcad50cf903a75bb0 Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* Gerrit: Show only gerrit remotes in Push to Gerrit dialogOrgad Shaneh2017-07-011-21/+12
| | | | | | Task-number: QTCREATORBUG-16367 Change-Id: I18e24dd0748bd64790bd8d2c0eeeee2cf1d3991a Reviewed-by: André Hartmann <aha_1980@gmx.de>
* Remove spaces in initializer listsTim Jenssen2017-02-221-2/+2
| | | | | | | Format initializer lists code style like. Change-Id: Ib82c235e4ba7dc75ee96a7abc0c47eff7b0a9013 Reviewed-by: hjk <hjk@qt.io>
* Git: Eradicate Q_FOREACH loopsOrgad Shaneh2017-02-061-5/+6
| | | | | | Change-Id: I29b6071ea244d1b3ae0701d36c90b1e93cf21fbb Reviewed-by: André Hartmann <aha_1980@gmx.de> Reviewed-by: hjk <hjk@qt.io>
* Git: Persist topic per branch on Push to GerritOrgad Shaneh2017-01-231-0/+11
| | | | | Change-Id: I5a4056f562bb3264a8bd35d73fb16860eb0984e7 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Git: Use Utils::Icon for IconItemDelegate constructorAlessandro Portale2016-10-111-1/+3
| | | | | | | | Use our icon abstraction instead of file names, because themed icons are coming. Change-Id: I0f4e44caf96aeab0c354d2166b111d59b7b29149 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Git: Fix initially disabled OK button in Push to GerritOrgad Shaneh2016-10-051-0/+1
| | | | | Change-Id: I7223ef113781eb9adae59dba58036c19a96a11b0 Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* Gerrit: Support pushing initial commit for reviewOrgad Shaneh2016-09-121-4/+20
| | | | | | | | | Enable manual selection of target branch on this case. Task-number: QTCREATORBUG-16780 Change-Id: I925ceef52ec56ebf77abcee58065c7b8afcc0854 Reviewed-by: André Hartmann <aha_1980@gmx.de> Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* Git: De-noiseOrgad Shaneh2016-07-221-29/+25
| | | | | | | | | * Remove QLatin1{String|Char} where possible * Use initializer lists for QStringList Change-Id: I8479f87f4fc909b5d74d854956885564209538e4 Reviewed-by: Christian Stenger <christian.stenger@qt.io> Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* Git: Hide obsolete branches by default in branches dialogOrgad Shaneh2016-03-101-1/+2
| | | | | | | Task-number: QTCREATORBUG-15544 Change-Id: I411c7eacd2c154cad08234c0bd22e16dfecb961c Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com> Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
* Git: ModernizeTobias Hunger2016-02-101-9/+7
| | | | | | | | | | * pragma once * member initialization * s/struct/class/ * Introduce a static GitPlugin::client() method and use it Change-Id: Ifdcac86dd16f3cdba11d564d03e9a15f00a6afdb Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Preferably use QStringRef::toInt().Friedemann Kleint2016-02-041-1/+1
| | | | | | | Avoid allocations for converting to int. Change-Id: Id8c79334f4809ec075ffe7e6b7635be4873eafd8 Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
* Update License according to agreement with Free Qt FoundationTobias Hunger2016-01-191-16/+11
| | | | | | | * Update files in src/plugins Change-Id: Ia5d77fad7d19d4bb3498e78661982f68729adb22 Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
* Git: Add overrideOrgad Shaneh2015-04-121-1/+1
| | | | | Change-Id: Iae0779c1efa8b3b46cf504f7bda00d614a4a157e Reviewed-by: André Hartmann <aha_1980@gmx.de>
* Git: s/GitPlugin::gitClient/GitPlugin::client/Tobias Hunger2015-04-081-1/+1
| | | | | | | ... same name as with almost all other plugins. Change-Id: I964159044d86685735e8b1e816a0bf67e0576fd8 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Gerrit: Place gerrit and origin remotes firstOrgad Shaneh2015-02-161-0/+9
| | | | | | Change-Id: Icf74210934b92c3f794ccc764b8e526d51eafc2b Reviewed-by: Friedemann Kleint <Friedemann.Kleint@theqtcompany.com> Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
View Lorry Controller Status