summaryrefslogtreecommitdiff
path: root/CONTRIBUTING.md
Commit message (Collapse)AuthorAgeFilesLines
* Rename negative test "phase" for module resolutionMike Pennisi2018-01-051-1/+1
|
* Rename negative test "phase" for parsingMike Pennisi2018-01-051-3/+3
| | | | | | | | | | | | | | Early errors may result from parsing the source text of a test file, but they may also result from parsing some other source text as referenced through the ES2015 module syntax. The latter form of early error is not necessarily detectable by ECMAScript parsers, however. Because of this, the label "early" is not sufficiently precise for all Test262 consumers to correctly interpret all tests. Update the "phase" name of "early" to "parse" for all those negative tests that describe errors resulting from parsing of the file's source text directly. A forthcoming commit will update the remaining tests to use a "phase" name that is more specific to module resolution.
* Fix typoAdrian Heine2018-01-051-1/+1
|
* Correct path to helper files directory in "contributing" docsIvan Vyshnevskyi2017-12-211-1/+1
|
* Merge pull request #1374 from jugglinmike/contributing-typoRick Waldron2017-12-191-1/+1
|\ | | | | Correct metadata reference in "contributing" docs
| * Correct metadata reference in "contributing" docsMike Pennisi2017-12-101-1/+1
| |
* | Document steps for satisfying tool dependenciesMike Pennisi2017-12-021-3/+9
|/
* Merge pull request #1296 from rwaldron/more-about-featuresRick Waldron2017-10-261-2/+2
|\ | | | | CONTRIBUTING.md: More detail about "features"
| * CONTRIBUTING.md: More detail about "features"Rick Waldron2017-10-171-2/+2
| |
* | Fix mistake in test generation sectionValerie R Young2017-10-201-2/+2
|/
* CONTRIBUTING.md: Link #handling-errors-and-negative-test-cases (#1295)Rick Waldron2017-10-171-1/+1
|
* Fix generate test explinationValerie R Young2017-10-171-12/+17
|
* very WIP notes about autogenerate filesValerie R Young2017-10-121-2/+1
|
* update CONTRIBUTING.md to reflect current practicesValerie R Young2017-10-121-34/+37
|
* Fix CONTRIBUTING.md description of the info frontmatter tagValerie R Young2017-10-041-4/+19
|
* add note to list that esid is required for new tests onlydeathbearbrown2017-06-281-2/+2
|
* update contributing.md to make esid required for new feature testsdeathbearbrown2017-06-281-3/+3
|
* Enforce use of `throw` stmt in early error testsMike Pennisi2017-06-281-1/+3
| | | | | | | | | | | | | | | Previously, test consumers were encouraged to insert a `throw` statement as the first statement of tests for early errors. This recommendation made tests harder to consume, and as an optional transformation, consumers may have ignored it or simply been unaware it was made. By explicitly including such a `throw` statement, the tests become more literal, making them easier to consume and more transparent in their expectations. Document expectation for all tests for early errors to include an explicit `throw` statement. Extend linting script to verify that contributors are automatically notified of violations and to ensure that future contributions satisfy this expectation.
* CONTRIBUTING.md: Adds 'Source Material' section with 'needs tests' pr list ↵Rick Waldron2017-06-121-0/+6
| | | | (#1054)
* Lint test `features` tag (#1060)jugglinmike2017-06-121-1/+1
| | | | | | | | | | A recent commit introduced a document that enumerated acceptable values for the test "features" metadata tag. However, this list was incomplete, and maintaining it placed extra burden on the project owners. Restructure the document into a machine-readable format. Add entries for all previously-omitted values. Add in-line documentation with recommendations for maintenance of the file. Extend the project's linting tool to validate tests according to the document's contents.
* CONTRIBUTING: Fix typo (#1013)Mathias Bynens2017-05-011-1/+1
|
* Add assert.throws.earlyLeo Balter2017-05-011-1/+2
|
* Introduce automated validation for test format (#994)jugglinmike2017-05-011-0/+13
| | | | | | | This script is intended to identify common test file formatting errors prior to their acceptance into the project. It is designed to support future extensions for additional validation rules.
* CONTRIBUTING: Link to the latest spec draft (#978)Mathias Bynens2017-04-141-15/+15
|
* Automate deployment (#546)jugglinmike2017-04-101-0/+2
| | | | | | | | | | | | | | | | Introduce configuration to allow build servers provided by the Travis CI service to execute the test generation tool and commit the resultant files to the canonical upstream repository. Enabling this workflow required additional administrative work: 1. Create an account with TravisCI 2. Install the `travis` command-line utility 3. Create a "deploy key" and an encrypted version using the command `./make.py github_deploy_key_enc` 4. Register the deploy key with the project's GitHub account 5. Check the encrypted deploy key to the repository 6. Configure the TravisCI service to automatically build this project
* Document test flag: `generated` (#886)jugglinmike2017-03-061-0/+4
| | | Resolves gh-885
* Remove "NotEarlyError" objectMike Pennisi2016-10-191-11/+0
| | | | | | | | | | Because expectations regarding error "phase" are now expressed via test meta-data, the test runner may now enforce this requirement on negative tests. Remove the "NotEarlyError" from the project source. This reduces the amount of domain knowledge required to author tests and lessens the potential for inconsistencies between tests.
* Update documentationMike Pennisi2016-10-191-3/+12
|
* Fix markdown typo (#763)Tim Disney2016-09-271-1/+1
|
* Fix operator precedence (#754)Aleksey Shvayka2016-09-011-1/+1
| | | Unlike PHP, in JavaScript ! has higher precedence than instanceof, thus !smth instanceof TypeError will never (unless @@hasInstance is defined) be true.
* Merge pull request #545 from bocoup/generationLeo Balter2016-04-151-0/+34
|\ | | | | Introduce test generation tool
| * Add initial set of generated test sourcesMike Pennisi2016-03-161-0/+34
| |
* | Correct example in contribution guidelinesMike Pennisi2016-03-221-2/+2
| | | | | | | | | | | | | | | | | | As written, the example for asserting runtime errors is written with an early error. Because the error is expected to be reported prior to program execution, the `assert.throws` function cannot be used to detect it. Demonstrate the usage of the helper function with a runtime error.
* | Merge pull request #504 from bocoup/explicit-asyncLeo Balter2016-03-171-1/+3
|\ \ | |/ |/| Make asynchronous test configuration explicit
| * Make asynchronous test configuration explicitMike Pennisi2016-02-121-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For asynchronous tests, the contract between test file and test runner is implicit: runners are expected to inspect the source code for references to a global `$DONE` identifier. Promote a more explicit contract between test file and test runner by introducing a new frontmatter "tag", `async`. This brings asynchronous test configuration in-line with other configuration mechanisms and also provides a more natural means of test filtering. The modifications to test files was made programatically using the `grep` and `sed` utilities: $ grep "\$DONE" test/ -r --files-with-match --null | \ xargs -0 sed -i 's/^\(flags:\s*\)\[/\1[async, /g' $ grep "\$DONE" test/ -rl --null | \ xargs -0 grep -E '^flags:' --files-without-match --null | \ xargs -0 sed -i 's/^---\*\//flags: [async]\n---*\//'
* | s/id/esidLeonardo Balter2016-02-221-4/+4
|/ | | | Fixes #477
* Update contribution guidelinesMike Pennisi2016-02-041-1/+1
| | | | | | It was recently decided to prefer the new `id` tag over the existing `es5id` and `es6id` tag when authoring tests. Update the contribution guidelines to reference the new tag.
* Replace "id" with "ID"Gorkem Yakin2016-01-291-2/+2
|
* Document frontmatter's id tagLeonardo Balter2016-01-291-2/+10
| | | | Fixes #477
* Implement `raw` flagMike Pennisi2015-07-071-0/+3
| | | | | | | | | | | | | | | | | Some tests involving the directive prologue are invalidated by source text transformations that insert executable code in the beginning of the script. Implement a `raw` flag that allows these tests to opt-out of this transformation. Update the relevant tests to use this flag (and remove references to globals only available when code is injected). Update the Python runner accordingly: - Do not run tests marked as "raw" in strict mode - Reject invalid test configurations Update the browser runner accordingly: - Do not modify the script body of tests marked as "raw"
* Merge pull request #305 from jugglinmike/browser-only-strictBrian Terlson2015-06-251-1/+1
|\ | | | | Update browser runner to honor `onlyStrict` flag
| * Update browser runner to honor `onlyStrict` flagMike Pennisi2015-06-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Unlike the console runner, the browser runner does not modify the strictness of tests prior to running them. Regardless of a given test's metadata, it runs every test exactly once, and it never enables strict mode. This means that tests intended to function in strict mode must declare the "use strict"; directive prologue in addition to the `onlyStrict` flag. For any test that specifies the `onlyStrict` metadata flag, transform the source code by injecting a "use strict" directive prologue prior to running the test.
* | Update spec references to use canonical sourceMike Pennisi2015-06-241-3/+3
|/
* Add tests for early errors in module syntaxMike Pennisi2015-06-031-0/+2
| | | | | Introduce the `module` flag to unambiguously identify tests that are intended to be interpreted as module code.
* Update contribution guidelinesMike Pennisi2015-06-031-82/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Remove trailing white space - Streamline documentation of test tags - Do not reference obsolete tags - Document `features` frontmatter tag - Document `es6id` frontmatter tag - Omit unnecessary detail about test262 website generation. This is not directly useful to potential test contributors. Implementation details like these can be taken for granted by that audience. - Remove documentation on YAML syntax. Details on YAML may be helpful for some new contributors, but this document should not attempt to cover the topic (especially not from the description of a specific frontmatter entry). Replace with a link to a more comprehensive source as this will be more generally useful to those who need it (and less obtrusive for those who do not). - Consolidate information on test helpers - Document `assert` helpers - Update instructions for asserting errors. Since the introduction of `assert.throws` in gh-22, the preferred means of expressing expectations regarding errors has changed. Update the CONTRIBUTING.md file to reflect the latest approach. Explain purpose of `throw NotEarlyError;` in example test. - Re-order information on file names. The inconsistency in the project's file names should not go unmentioned, but neither should it not preceed instructions for the accepted approach to namine tests. - More clearly document required frontmatter tags. Explicitly list `description` as a required frontmatter tag, implicitly identifying all other tags as optional.
* Update copyright year in sample copyrightDomenic Denicola2015-02-171-1/+1
|
* Contributing: updates the Test Case Names section. Closes gh-150. Closes gh-136Rick Waldron2015-02-161-11/+6
|
* document `timeout` and clean upSam Mikes2014-08-251-47/+82
| | | | | | | | | | | | | | | | | | CONTRIBUTING.md - document `timeout` tag - reorder tags in frontmatter doc - minor cleanups - minor fixes - add style note - reformat flags - remove discussion of obsolete $INCLUDE - incorporate line notes from @domenic - integrate additional comments - add links back, move arg notes down - Raise outline level by one README.md - link to CONTRIBUTING
* CONTRIBUTING.md: minor fixessmikes2014-07-311-11/+19
| | | | Minor fixes: typos, formatting, verb tense&agreement Add example of short-list `includes: []` and long-list `includes: \n - \n -`
* CONTRIBUTING: more notes on test writingSam Mikes2014-07-311-116/+112
| | | | | | | | | | | | | | | | | Add section on test environment Add section on custom helpers describe YAML frontmatter Fix minor formatting errors document $INCLUDE as obsolete Change documentation of negative error Move test environment and custom helpers down indent copyright and frontmatter sections better description of the async calls between a promise and the functions in its `.then` Correct Early Error example: don't throw a string CONSOLE-RUNNER: split runner doc into new file add troubleshooting section
View Lorry Controller Status