Qt Designer: Fix clang-tidy warnings about Qt usage

- Use multi-arg form of QString::arg()
- Fix static method calls
- Prefer QFileInfo::exists()
- Use isEmpty() for containers instead of checking size()
- Use QOverload

Change-Id: I31e92f77d0fa377932c1369afe2503abc8ecceac
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>

1 files changed, 4 insertions, 2 deletions

diff --git a/src/designer/src/lib/shared/iconselector.cpp b/src/designer/src/lib/shared/iconselector.cpp
index 303a2e2a6..f84b30173 100644
--- a/src/designer/src/lib/shared/iconselector.cpp
+++ b/src/designer/src/lib/shared/iconselector.cpp
@@ -321,7 +321,8 @@ bool IconSelector::checkPixmap(const QString &fileName, CheckMode cm, QString *e
     QImageReader reader(fileName);
     if (!reader.canRead()) {
         if (errorMessage)
-            *errorMessage = tr("The file '%1' does not appear to be a valid pixmap file: %2").arg(fileName).arg(reader.errorString());
+            *errorMessage = tr("The file '%1' does not appear to be a valid pixmap file: %2")
+                              .arg(fileName, reader.errorString());
         return false;
     }
     if (cm == CheckFast)
@@ -330,7 +331,8 @@ bool IconSelector::checkPixmap(const QString &fileName, CheckMode cm, QString *e
     const QImage image = reader.read();
     if (image.isNull()) {
         if (errorMessage)
-            *errorMessage = tr("The file '%1' could not be read: %2").arg(fileName).arg(reader.errorString());
+            *errorMessage = tr("The file '%1' could not be read: %2")
+                               .arg(fileName, reader.errorString());
         return false;
     }
     return true;