summaryrefslogtreecommitdiff
path: root/telepathy-glib/connection-handles.c
Commit message (Collapse)AuthorAgeFilesLines
* Deprecate tp_connection_hold_handles()Xavier Claessens2012-05-101-0/+7
| | | | | | | Holding handles is not needed with Connection Managers having immortal handles (any Connection Manager using telepathy-glib >= 0.13.8). Other Connection Managers are considered deprecated, clients wanting to still support them should continue using this deprecated function.
* Deprecate tp_connection_request_handles()Xavier Claessens2012-05-101-0/+6
| | | | Everywhere we need an handle, we can give an ID nowadays.
* Deprecate tp_connection_get_contact(_list)_attributesXavier Claessens2012-05-101-0/+4
| | | | | Contact attributes is an internal concept that should not appear in our API.
* Deprecate tp_handle(s)_ref/unref, tp_handle(s)_client_hold/release and ↵Xavier Claessens2012-05-101-0/+2
| | | | | | tp_connection_unref_handles() They are no-op now, so we can safely remove them all
* Use TP_NUM_… instead of NUM_TP_…Simon McVittie2012-04-121-2/+2
| | | | | | Based on a patch from Jonny Lamb, updated for current master. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=46470
* Add config.h include in all source filesXavier Claessens2012-02-061-0/+2
|
* Use _unref instead of _free _destroy when possible.Xavier Claessens2011-11-161-2/+2
| | | | | | | | | | | Replace g_(ptr_)array_free (foo, TRUE) and g_hash_table_destroy with respectively g_(ptr_)array_unref (foo) and g_hash_table_unref. I used this command to generate this patch: for f in `find -name "*.c"`; do sed -i $f -re 's/g_ptr_array_free \(([^ ,]+), TRUE\)/g_ptr_array_unref \(\1\)/'; done See Danielle's blog for explanation of possible bug _free can do: http://blogs.gnome.org/danni/2011/11/16/mistakes-with-g_value_set_boxed/
* Prepare version 0.13.8telepathy-glib-0.13.8Simon McVittie2010-12-011-5/+5
|
* TpConnection: don't track references to handlesSimon McVittie2010-12-011-303/+38
| | | | There's no need, now that we never release them.
* tp_connection_unref_handles: don't do anythingSimon McVittie2010-12-011-122/+6
| | | | | This gets us a little closer to the "immortal handles" behaviour even for CMs that have refcounting.
* Merge branch 'contact-list'Simon McVittie2010-09-221-0/+59
|\ | | | | | | | | | | | | | | | | | | Conflicts: docs/reference/telepathy-glib-sections.txt examples/cm/contactlist/contact-list-manager.c spec/Connection_Interface_Contact_Groups.xml spec/Connection_Interface_Contact_List.xml spec/errors.xml telepathy-glib/errors.c
| * Merge branch 'master' into contact-list-the-revengeSimon McVittie2010-08-251-1/+1
| |\
| * | Update ContactList spec to draft 3, but for the moment keep draft 2 semanticsSimon McVittie2010-07-191-3/+3
| | |
| * | Update ContactList, ContactGroups spec to tp-spec masterSimon McVittie2010-06-291-2/+2
| | | | | | | | | | | | | | | This renames GetContactListAttributes to RequestContactList; all the other spec changes were already implemented in this branch.
| * | Correct documentation of tp_connection_request_contact_list_attributes()Simon McVittie2010-06-071-14/+8
| | | | | | | | | | | | As per Guillaume's review.
| * | tp_connection_request_contact_list_attributes: addSimon McVittie2010-06-071-0/+65
| | | | | | | | | | | | | | | | | | This needs a specific binding for the same reasons as GetContactAttributes. I've called it _request_ rather than _get_ since I plan to rename the underlying D-Bus method at some point.
* | | Trivial annotation fixes for TpConnectionRequestHandlesCbPhilip Withnall2010-09-141-2/+3
| |/ |/| | | | | Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* | Fix various broken cross-references in documentationSimon McVittie2010-08-231-1/+1
|/
* Remove trailing whitespaceSimon McVittie2010-05-241-1/+1
|
* Added element-type and transfer annotations to garray argumentsMorten Mjelva2010-05-241-2/+2
| | | | | | Skipped tp_g_value_slice_* functions in dbus.c Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* Merge branch 'error-macros'Simon McVittie2010-05-031-3/+4
|\ | | | | | | Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
| * Use macros WARNING(), etc., consistently (within the library)Simon McVittie2010-04-301-2/+2
| |
| * TpConnection: if RequestHandles returns the wrong length, raise errorSimon McVittie2010-04-301-1/+2
| | | | | | | | | | | | | | Previously, we mistakenly passed error (which is NULL on this code path) to client code; this should have been e, the new GError we just allocated. Also, don't leak that GError.
* | Add/correct gobject-introspection annotation for TpConnection and ↵Danielle Madeley2010-05-031-7/+7
|/ | | | TpConnectionManager
* Initial work on generating gobject-introspectionDanielle Madeley2010-04-251-2/+2
|
* connection_got_contact_attributes: don't display debug message if an error ↵Guillaume Desmottes2010-04-201-2/+3
| | | | | | | occured If something went wrong attributes is NULL so we can't call g_hash_table_size on it (fdo #27537).
* Document client-side handle reference counting.Will Thompson2009-05-281-2/+13
| | | | | | Fixes fd.o #19741 Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* Don't hold handles if GetContactAttributes failsWill Thompson2009-04-071-1/+1
| | | | | | | Calling _tp_connection_ref_handles on an invalidated connection (which self will be here if error is non-NULL) asserts. Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* Linkify a reference to #TpProxy::invalidatedWill Thompson2009-01-071-1/+1
|
* Warn against using handle-holding D-Bus APIs directlySimon McVittie2008-11-061-0/+11
|
* tp_connection_get_contact_attributes: addSimon McVittie2008-11-061-0/+135
| | | | | This is a wrapper for GetContactAttributes that correctly updates the handle reference tracking infrastructure if @hold is TRUE.
* tp_connection_unref_handles: if no handles are to be released, don't leak memorySimon McVittie2008-10-221-0/+4
|
* connection-handles: When doing a g_return_if_fail for something that ↵Simon McVittie2008-10-131-2/+3
| | | | | | obscurely indicates user error, indicate what they did wrong From the "abuse of the comma operator" department.
* connection-handles: replace a couple of inappropriate g_message calls with ↵Simon McVittie2008-10-131-2/+2
| | | | DEBUG()
* _tp_connection_ref_handles, tp_connection_unref_handles: simplify allocation ↵Simon McVittie2008-10-131-51/+30
| | | | | | | | of data structures _tp_connection_init_handle_refs now preallocates some of the data structures, so we can just assert that they're good rather than allocating them lazily.
* tp_connection_request_handles: add more checks and do not allow requesting 0 ↵Simon McVittie2008-10-131-9/+9
| | | | handles
* tp_connection_hold_handles: add more checks, and do not allow holding 0 handlesSimon McVittie2008-10-131-1/+7
|
* tp_connection_unref_handles: add more checks, and document that it's a no-op ↵Simon McVittie2008-10-131-2/+6
| | | | on invalidated connections
* tp_connection_unref_handles: turn an assert into a return_if_failSimon McVittie2008-10-131-1/+1
| | | | | Passing an out-of-range handle type is library user error, so we should g_return_if_fail on it.
* connection-handles: Don't forget handles until *all* TpConnections sharing a ↵Simon McVittie2008-10-131-17/+75
| | | | | | | bucket have been invalidated TpConnection emits invalidated when it runs out of refs, so this is necessary for correct sharing of buckets.
* Don't free handle-ref-tracking data structures until the connection is ↵Simon McVittie2008-10-131-22/+0
| | | | | | | invalidated This avoids repeated alloc/free cycles if a connection oscillates between holding 0 and 1 handles.
* Amend a comment to indicate that no, we can't combine unrefs via g_idle_addSimon McVittie2008-10-131-2/+4
|
* Improve wording of TpConnectionRequestHandlesCb, TpConnectionHoldHandlesCb docsSimon McVittie2008-10-131-2/+2
| | | | | It was previously unclear whether it was the same pointer, or a pointer to a copy.
* TpConnection: add handle ref/hold/release functionalitySimon McVittie2008-10-131-0/+619
This centralizes handle ref tracking, because otherwise calling ReleaseHandles is inherently unsafe - you never know whether another part of the process is still using the handles. In this implementation the handles are stored in a data-slot on the DBusConnection. See mailing list thread "Uniqueness of objects", starting with Message-ID: <20080930200125.GA15304@carbon.pseudorandom.co.uk>