| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
updated
This lets us get AccountPropertyChanged signals for more attributes
changed via McpAccountStorage::altered-one, which would previously be
suppressed because altered-one's API is that the storage plugin has
already updated the McdStorage before emitting the signal. The
property setter would then notice that the value was the same as
in McdStorage, and assume that that meant it hadn't actually changed.
|
|
|
|
|
|
|
|
| |
We already depend on GLib 2.30, which is new enough.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54633
|
|
|
|
|
|
|
|
|
|
| |
This provided an asynchronous API for getting and setting properties,
which nothing actually calls into, and nothing in MC supports setting
properties asynchronously anyway. Into the bin it goes!
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54633
|
|
|
|
|
|
| |
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=49753
|
|
|
|
|
|
| |
This is best-practice, and in particular it stops us from accidentally
redefining GLIB_VERSION_MIN_REQUIRED, GLIB_VERSION_MAX_ALLOWED by
including glib.h before (something that includes) config.h.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Replace g_(ptr_)array_free (foo, TRUE) and g_hash_table_destroy
with respectively g_(ptr_)array_unref (foo) and g_hash_table_unref.
I used this command to generate this patch:
for f in `find -name "*.c"`; do sed -i $f -re 's/g_ptr_array_free \(([^ ,]+), TRUE\)/g_ptr_array_unref \(\1\)/'; done
See Danielle's blog for explanation of possible bug _free can do:
http://blogs.gnome.org/danni/2011/11/16/mistakes-with-g_value_set_boxed/
|
|
|
|
|
|
|
| |
This entails doing a little more code generation for the daemon: some
bits depended on generated code from libmcclient, and there was an error
enum used in exactly one place. But broadly speaking this just deletes a
tonne of code and documentation.
|
|
|
|
|
|
|
|
|
|
|
| |
Defining an interface as MCD_IMPLEMENT_OPTIONAL_IFACE() indicates it should
not be included in an object's Interface property by default. Instead the
interface is activated by calling mcd_dbus_activate_optional_interface() on
an individual object instance.
This makes it possible to implement interfaces such as
Acct.I.ExternalPasswordStorage only on accounts whose Connection Manager
supports it.
|
|
|
|
|
|
| |
The only property that was implemented in an async fashion was
Account.Parameters. Since that's now synchronous, we can bin this code
for getting properties asynchronously.
|
| |
|
|
|
|
|
|
|
| |
Getting the Parameters property is still broken because the Parameters
property hasn't implemented an async get function.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
|
|
| |
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All the interfaces and GTypes we need are already in libmcclient, with the
same names and auto-generated implementations, so it's useless to generate
them in libmissioncontrol-server.
When configured with --enable-static --disable-shared (which is what we
want in Debian, I suspect), it becomes actively harmful to have two
implementations: shared library linking can survive colliding symbols
(at least on Linux), but static linking can't.
(If we ever want Mission Control to be independent of libmcclient, then
it should generate its own quark/type functions in the Mcd namespace.)
|
| |
|
|
|
|
|
|
|
| |
The new implementation of set_avatar() looks suspicious: it changes the
interpretation of _mcd_account_set_avatar's boolean return value from
"changed" to "no error". However, _mcd_account_set_avatar either returns
FALSE with a GError, or TRUE, in all cases, so this is actually OK.
|
|
|
|
|
|
|
| |
It's generally bad practice for the only indication of error or not to be
whether a GError was written through a GError** - you're meant to be able
to pass NULL if you don't care which error it was, and still see whether
it's success or failure.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Add vim and emacs modelines to avoid using tabs in newly-written code.
|
|
|
|
| |
git-svn-id: https://mission-control.svn.sourceforge.net/svnroot/mission-control/trunk@523 d91c8aed-3f2b-0410-a83d-924a1c20a0ba
|
|
|
|
| |
git-svn-id: https://mission-control.svn.sourceforge.net/svnroot/mission-control/trunk@513 d91c8aed-3f2b-0410-a83d-924a1c20a0ba
|
|
|
|
| |
git-svn-id: https://mission-control.svn.sourceforge.net/svnroot/mission-control/trunk@457 d91c8aed-3f2b-0410-a83d-924a1c20a0ba
|
|
|
|
| |
git-svn-id: https://mission-control.svn.sourceforge.net/svnroot/mission-control/trunk@402 d91c8aed-3f2b-0410-a83d-924a1c20a0ba
|
|
|
|
|
|
|
|
| |
''Interfaces'' property for the Account class.
git-svn-id: https://mission-control.svn.sourceforge.net/svnroot/mission-control/trunk@362 d91c8aed-3f2b-0410-a83d-924a1c20a0ba
|
|
|
|
|
|
|
|
| |
properties.
git-svn-id: https://mission-control.svn.sourceforge.net/svnroot/mission-control/trunk@352 d91c8aed-3f2b-0410-a83d-924a1c20a0ba
|
|
specifications.
git-svn-id: https://mission-control.svn.sourceforge.net/svnroot/mission-control/trunk@314 d91c8aed-3f2b-0410-a83d-924a1c20a0ba
|