| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
ebdefa2745 tried to fix handling of relative symlinks in archives, but that
only addressed targets starting with ".."/. Fix it properly by using
asb_utils_sanitise_path only for absolute paths, keep relative paths as-is.
Simplify code for handling absolute symlinks by just prepending the root
instead of converting it to a relative link.
Hardlink targets are returned as paths relative to the archive root, so the
sanitization code is correct there.
|
|
|
|
|
|
|
|
|
| |
dbd62f6e05 removed the WxH directory from the icon filenames, which were also
used as-is for the paths in the icons tarball. However, if width and height
are set on the icon, then it has to be inside a size-specific directory.
With HiDPI enabled, it did even overwrite the non-HiDPI icon it saved just
before because the filenames were the same.
Add the subdirectory back in the resource handling code.
|
|
|
|
| |
Signed-off-by: Rafael Fontenelle <rffontenelle@gmail.com>
|
|
|
|
|
|
|
| |
According to the specification, there is no difference between both kinds
of upstream metainfo files.
Fixes #381
|
|
|
|
| |
Fixes https://github.com/hughsie/appstream-glib/issues/422
|
|
|
|
| |
This reverts commit 3fa624026f608ef8465fb339f86725aaf648e09f.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
Integrates these commits:
https://github.com/ximion/appstream/commit/e42dd0d071f27d74419b04a52a8388e00777cd88
https://github.com/ximion/appstream/commit/71d134e82752be6f8851c65ba0ce8c312a72214c
https://github.com/ximion/appstream/commit/8c939f999ebf82c3bbf5ad179b24fd7478a0f1d0
https://github.com/ximion/appstream/commit/51ab4f32c56f5cdc293ba0512f003542b83713fc
|
| |
|
| |
|
|
|
|
|
|
| |
Always store the AppStream metadata version as a string and compare it
like any other version.
This allows to have 0.10 > 0.8 for instance.
|
|
|
|
| |
mingw clang does not support --version-script linker option.
|
|
|
|
|
|
| |
We are now in version 0.14
Signed-off-by: Corentin Noël <corentin.noel@collabora.com>
|
|
|
|
| |
Translation by Henrique Machado, Proofread by Enrico
|
|
|
|
| |
Some appstream-data packages add <em> and </em> or <code> and </code> to the files. Not all package manager can handle that. An example would be pamac from Manjaro
|
|
|
|
|
| |
Apparently, write ordering of some field schanged at some point, but the
test case was not updated. Updating to allow Travis CI to pass.
|
|
|
|
|
|
|
|
| |
AppStream license syntax allows constructs of form "LICENSE1 AND
LICENSE2". It is possible to confuse this with writing multiple license
xml elements in a metainfo file. In order to spot this type of error,
duplicate detection is added for xml elements metadata_license and
project_license.
|
|
|
|
|
|
|
|
|
| |
Ideally only libappstream-builder would be fixed, but
asb_utils_ensure_exists is (transitively) called from builder too, so
fixing also that.
Fixes: #399
Merges: #400
|
| |
|
|
|
|
| |
Fixes https://github.com/hughsie/appstream-glib/issues/396
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As per
https://www.freedesktop.org/software/appstream/docs/sect-AppStream-IconCache.html#spec-iconcache-location,
the size of an icon should be specified in its `width` and `height`
attributes, rather than as part of its name.
This was resulting in icons like this in the rpmfusion-free-33 appdata:
```
<icon type="cached" height="128" width="128">128x128/chromium-browser-privacy.png</icon>
```
which were then being resolved to the path:
```
/usr/share/app-info/icons/rpmfusion-free-33/128x128/128x128/chromium-browser-privacy.png
```
which contains a duplicate size subdirectory.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
|
|
|
|
|
|
|
| |
Markdown underlines are with `=` or `-`, not `~`. This fixes the
Markdown rendering of appdata-to-news-ed files in GitLab.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
|
|
|
|
|
| |
Replace links http://standards.freedesktop.org/...
by https://specifications.freedesktop.org/...
|
|
|
|
|
| |
Replace a link http://www.freedesktop.org/wiki/...
by https://www.freedesktop.org/wiki/...
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
Align the OARS/CSM mappings of sex-homosexuality and sex-themes, as the
two are identical apart from discriminating on sexual orientation.
This is a follow-up to commit 01e9ee8113a8ad.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Avoiding storing identical strings is a clever measure to keep the
appstream file small and clean, but it ignores translation differences
between languages and their specific locales.
Applications tend to "fallback" from missing locales by picking a
translation of the same language but from a different locale.
For instance, when missing a "pt_BR" translation, some apps will
pick the "pt" translation instead. That usually works but there
are some cases when it doesn't, such as for international words:
Brazilian Portuguese (pt_BR) tends to use them, while European
Portuguese (pt) has a translation for everything.
This way, "GNOME Boxes" gets translated to "Caixas GNOME" in
European Portuguese (pt) but the same "GNOME Boxes" name is
expected in Brazilian Portuguese (pt_BR).
This was initially reported as a Flatpak issue in
https://lists.freedesktop.org/archives/flatpak/2019-May/001578.html
Because OP was seeing the wrong translations in Flathub and
GNOME Software.
Original commit was done by @felipeborges in his personal branch at
github, commit 54f97aadcd2c00f3d95b472db6e4dda1c0c9865b
|
|
|
|
| |
* Update Croatian translation
|
| |
|
| |
|
|
|
|
|
| |
We managed to merge two MRs to initialize the unique id mutex. Remove
one of the g_mutex_init calls to avoid doing it twice.
|
|
|
|
|
|
| |
This might make the descriptions a little clearer.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This rationalises it with the OARS/CSM mapping of
sex-themes/intense, and with many western societal norms. It is
against the laws and morals of various western countries to discriminate
on sexual orientation, so the mappings for sex-homosexuality/intense and
sex-themes/intense should be the same.
The mappings for the other values of sex-homosexuality and sex-themes
remain different, as their descriptions aren’t as comparable (for
example, for `mild`, the descriptions are “Indirect references to
homosexuality” vs “Provocative references or descriptions”).
The sex-homosexuality ratings category does need to continue to exist,
though, as it’s illegal in some countries to *not* discriminate on
sexual orientation. Those countries can provide and maintain their own
OARS/age mappings.
See https://gitlab.freedesktop.org/pwithnall/malcontent/-/issues/21.
This issue is now being solved in appstream-glib as the content rating
code has been moved there so it can be shared between malcontent and
gnome-software.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The translations have been imported unmodified, by updating the local
translations (`ninja appstream-glib-update-po`), then catting in the
translations from gnome-software (roughly `for i in *.po; do msgcat $i
../gnome-software/po/$i; done`), then updating the local translations
again, and cutting off the unnecessary new fuzzy strings.
I have not verified any of the translations are correct, as I can’t
speak any of these languages.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
|
|
|
|
|
|
| |
This simply reformats them. Done using `ninja appstream-glib-update-po`.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These are moving to libappstream-glib as they are used by gnome-software
and libmalcontent-ui, and are potentially useful in other projects. In
particular, there are a number of translatable strings which need to be
centralised so that translation work isn’t repeated.
This code was originally written by:
• Richard Hughes <richard@hughsie.com>
• Piotr Drąg <piotrdrag@gmail.com>
• Philip Withnall <withnall@endlessm.com>
• Jordi Mas <jmas@softcatala.org>
It was previously in `src/gs-content-rating.[ch]` in gnome-software,
under the GPL-2.0+; and in `libmalcontent-ui/gs-content-rating.[ch]` in
malcontent, also under the GPL-2.0+. It has been relicensed from
GPL-2.0+ to LGPL-2.1+ for the move to appstream-glib, and all the
previous contributors have agreed. See
https://github.com/hughsie/appstream-glib/pull/364#issuecomment-632773905
and below for their agreements.
In moving it from one project to the other, I have added documentation
comments and tweaked some of the APIs to make them more usable.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
|
| |
|
|
|
|
|
|
| |
It segfaulted when building the error message as data_c->name was invalid.
data_c was a valid tag, so only the data_c->tag union member was active.
Fix the crash by calling the proper function instead and add a test case.
|
|
|
|
|
| |
That should fix FTBFS on some architectures
Fixes: #356
|