summaryrefslogtreecommitdiff
path: root/client/network_inspect_test.go
Commit message (Collapse)AuthorAgeFilesLines
* client: update error-assertions in testsSebastiaan van Stijn2023-05-101-6/+7
| | | | | | | | - use is.ErrorType - replace uses of client.IsErrNotFound for errdefs.IsNotFound, as the client no longer returns the old error-type. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
* client: remove wrapResponseError()Sebastiaan van Stijn2022-03-201-4/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The wrapResponseError() utility converted some specific errors, but in doing so, could hide the actual error message returned by the daemon. In addition, starting with 38e6d474affe08230043fa36fa02f623c2ab2661, HTTP status codes were already mapped to their corresponding errdefs types on the client-side, making this conversion redundant. This patch removes the wrapResponseError() utility; it's worth noting that some error-messages will change slightly (as they now return the error as returned by the daemon), but may cointain more details as before, and in some cases prevents hiding the actual error. Before this change: docker container rm nosuchcontainer Error: No such container: nosuchcontainer docker container cp mycontainer:/no/such/path . Error: No such container:path: mycontainer:/no/such/path docker container cp ./Dockerfile mycontainer:/no/such/path Error: No such container:path: mycontainer:/no/such docker image rm nosuchimage Error: No such image: nosuchimage docker network rm nosuchnetwork Error: No such network: nosuchnetwork docker volume rm nosuchvolume Error: No such volume: nosuchvolume docker plugin rm nosuchplugin Error: No such plugin: nosuchplugin docker checkpoint rm nosuchcontainer nosuchcheckpoint Error response from daemon: No such container: nosuchcontainer docker checkpoint rm mycontainer nosuchcheckpoint Error response from daemon: checkpoint nosuchcheckpoint does not exist for container mycontainer docker service rm nosuchservice Error: No such service: nosuchservice docker node rm nosuchnode Error: No such node: nosuchnode docker config rm nosuschconfig Error: No such config: nosuschconfig docker secret rm nosuchsecret Error: No such secret: nosuchsecret After this change: docker container rm nosuchcontainer Error response from daemon: No such container: nosuchcontainer docker container cp mycontainer:/no/such/path . Error response from daemon: Could not find the file /no/such/path in container mycontainer docker container cp ./Dockerfile mycontainer:/no/such/path Error response from daemon: Could not find the file /no/such in container mycontainer docker image rm nosuchimage Error response from daemon: No such image: nosuchimage:latest docker network rm nosuchnetwork Error response from daemon: network nosuchnetwork not found docker volume rm nosuchvolume Error response from daemon: get nosuchvolume: no such volume docker plugin rm nosuchplugin Error response from daemon: plugin "nosuchplugin" not found docker checkpoint rm nosuchcontainer nosuchcheckpoint Error response from daemon: No such container: nosuchcontainer docker checkpoint rm mycontainer nosuchcheckpoint Error response from daemon: checkpoint nosuchcheckpoint does not exist for container mycontainer docker service rm nosuchservice Error response from daemon: service nosuchservice not found docker node rm nosuchnode Error response from daemon: node nosuchnode not found docker config rm nosuchconfig Error response from daemon: config nosuchconfig not found docker secret rm nosuchsecret Error response from daemon: secret nosuchsecret not found Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
* client: use subtests for TestNetworkInspectSebastiaan van Stijn2021-08-271-70/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Unify the NetworkInspect tests to remove some boilerplating Before this change: go test -v -run TestNetworkInspect ./client/ === RUN TestNetworkInspectError --- PASS: TestNetworkInspectError (0.00s) === RUN TestNetworkInspectNotFoundError --- PASS: TestNetworkInspectNotFoundError (0.00s) === RUN TestNetworkInspectWithEmptyID --- PASS: TestNetworkInspectWithEmptyID (0.00s) === RUN TestNetworkInspect --- PASS: TestNetworkInspect (0.00s) PASS ok github.com/docker/docker/client 0.010s With this change: go test -v -run TestNetworkInspect ./client/ === RUN TestNetworkInspect === RUN TestNetworkInspect/empty_ID === RUN TestNetworkInspect/no_options === RUN TestNetworkInspect/verbose === RUN TestNetworkInspect/global_scope === RUN TestNetworkInspect/unknown_network === RUN TestNetworkInspect/server_error --- PASS: TestNetworkInspect (0.00s) --- PASS: TestNetworkInspect/empty_ID (0.00s) --- PASS: TestNetworkInspect/no_options (0.00s) --- PASS: TestNetworkInspect/verbose (0.00s) --- PASS: TestNetworkInspect/global_scope (0.00s) --- PASS: TestNetworkInspect/unknown_network (0.00s) --- PASS: TestNetworkInspect/server_error (0.00s) PASS ok github.com/docker/docker/client 0.012s Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
* refactor: move from io/ioutil to io and os packageEng Zer Jun2021-08-271-3/+3
| | | | | | | | The io/ioutil package has been deprecated in Go 1.16. This commit replaces the existing io/ioutil functions with their new definitions in io and os packages. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* bump gotest.tools v3.0.1 for compatibility with Go 1.14Sebastiaan van Stijn2020-02-111-2/+2
| | | | | | full diff: https://github.com/gotestyourself/gotest.tools/compare/v2.3.0...v3.0.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
* Merge pull request #40080 from thaJeztah/client_string_matchingKirill Kolyshkin2019-10-171-1/+4
|\ | | | | client: reduce string-matching in tests
| * client: reduce string-matching in testsSebastiaan van Stijn2019-10-131-1/+4
| | | | | | | | | | | | | | | | These checks were redundant, as we were not expecting a specific string, just that a server-error or authentication error was returned. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
* | client: use constants for http methodsSebastiaan van Stijn2019-10-131-1/+1
|/ | | | Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
* Update tests to use gotest.tools 👼Vincent Demeester2018-06-131-2/+2
| | | | Signed-off-by: Vincent Demeester <vincent@sbr.pm>
* Switch from x/net/context -> contextKir Kolyshkin2018-04-231-1/+1
| | | | | | | | | | | Since Go 1.7, context is a standard package. Since Go 1.9, everything that is provided by "x/net/context" is a couple of type aliases to types in "context". Many vendored packages still use x/net/context, so vendor entry remains for now. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
* Automated migration usingDaniel Nephin2018-03-161-5/+6
| | | | | | gty-migrate-from-testify --ignore-build-tags Signed-off-by: Daniel Nephin <dnephin@docker.com>
* Merge pull request #36144 from emil2k/node-id-requiredTõnis Tiigi2018-02-161-0/+13
|\ | | | | Produce errors when empty ids are passed into inspect calls.
| * Produce errors when empty ids are passed into inspect calls.Emil Davtyan2018-02-071-0/+13
| | | | | | | | | | | | | | | | | | | | | | If a blank nodeID was previously passed in it resulted in a node list request. The response would then fail to umarshal into a `Node` type returning a JSON error. This adds an extra validation to all inspect calls to check that the ID that is required is provided and if not return an error. Signed-off-by: Emil Davtyan <emil2k@gmail.com>
* | Add canonical import commentDaniel Nephin2018-02-051-1/+1
|/ | | | Signed-off-by: Daniel Nephin <dnephin@docker.com>
* Cleanup client not found errors.Daniel Nephin2017-09-111-8/+5
| | | | | | And fix remove calls to return a notFound error Signed-off-by: Daniel Nephin <dnephin@docker.com>
* Add `scope` filter in `/networks/<id>`Yong Tang2017-06-121-5/+16
| | | | | | | | | | | | | | | | | | | | | | | This fix tries to add a `scope` in the query of `/networks/<id>` (`NetworkInspect`) so that in case of duplicate network names, it is possible to locate the network ID based on the network scope (`local`, 'swarm', or `global`). Multiple networks might exist in different scopes, which is a legitimate case. For example, a network name `foo` might exists locally and in swarm network. However, before this PR it was not possible to query a network name `foo` in a specific scope like swarm. This fix fixes the issue by allowing a `scope` query in `/networks/<id>`. Additional test cases have been added to unit tests and integration tests. This fix is related to docker/cli#167, moby/moby#30897, moby/moby#33561, moby/moby#30242 This fix fixes docker/cli#167 Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Enhance network inspect to show all tasks, local & non-local, in swarm modeSanthosh Manohar2017-03-131-6/+33
| | | | Signed-off-by: Santhosh Manohar <santhosh@docker.com>
* expected new_container_id while testing ContainerCommitlixiaobing100512672016-11-181-1/+1
| | | | Signed-off-by: lixiaobing10051267 <li.xiaobing1@zte.com.cn>
* client: remove transport packageStephen J Day2016-09-191-3/+3
| | | | | | | | | | | | | | This package doesn't really seem to do anything of real interest. Removing it and replacing with a few helper functions. Most of this was maintaining a fork of ctxhttp to support a mock that was unnecessary. We could probably do with a further refactor of the client interface. There is a lot of confusion of between transport, http layer and application layer that makes for some awkward code. This change improves the situation to the point where no breaking changes are introduced. Signed-off-by: Stephen J Day <stephen.day@docker.com>
* Move engine-api client packageMichael Crosby2016-09-071-0/+69
This moves the engine-api client package to `/docker/docker/client`. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
View Lorry Controller Status