The new instrumentation pays off.

On NMEA devices, mode could sometimes be held across cycles when it
shouldn't have been.  Fix this, simplifying how cycles are tracked in
the process.  Some regression tests needed rebuilding.  Code splints
clean.

1 files changed, 1 insertions, 9 deletions

diff --git a/driver_superstar2.c b/driver_superstar2.c
index 6ed59da5..4983a650 100644
--- a/driver_superstar2.c
+++ b/driver_superstar2.c
@@ -488,15 +488,7 @@ superstar2_dispatch(struct gps_device_t *session, unsigned char *buf,
     (void)snprintf(session->gpsdata.tag,
 	sizeof(session->gpsdata.tag), "SS2-%d", type);
 
-    /*
-     * Only one message sends actual fix data, so we can treat it as
-     * both start-of-cycle and end-of-cycle. For correctness, and in
-     * case the reports ever merge data from other sentences, we
-     * should find out what the actual cycle-ender is.
-     */
     session->cycle_end_reliable = true;
-    if (type == SUPERSTAR2_NAVSOL_LLA)
-	session->cycle_state |= CYCLE_START | CYCLE_END;
 
     switch (type)
     {
@@ -505,7 +497,7 @@ superstar2_dispatch(struct gps_device_t *session, unsigned char *buf,
     case SUPERSTAR2_SVINFO: /* Satellite Visibility Data */
 	return superstar2_msg_svinfo(session, buf, len);
     case SUPERSTAR2_NAVSOL_LLA: /* Navigation Data */
-	return superstar2_msg_navsol_lla(session, buf, len);
+	return superstar2_msg_navsol_lla(session, buf, len) | (CLEAR_SET | REPORT_SET);
 #ifdef __UNUSED__
     case SUPERSTAR2_NAVSOL_ECEF: /* Navigation Data */
 	return superstar2_msg_navsol_ecef(session, buf, len);